Bug 201888 - Stop calling Page::setSessionID() from WebKit2
Summary: Stop calling Page::setSessionID() from WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-17 15:45 PDT by Chris Dumez
Modified: 2019-09-17 19:25 PDT (History)
16 users (show)

See Also:

Attachments
Patch (16.95 KB, patch)
2019-09-17 15:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.41 KB, patch)
2019-09-17 15:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (18.04 KB, patch)
2019-09-17 16:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-17 15:45:48 PDT 
Stop calling Page::setSessionID() from WebKit2 since Page's sessionID can never change when using WebKit2 (We process-swap and create a new Page in a new process when changing data store).
Instead, we now pass the sessionID ID when constructing the Page, as part of the PageConfiguration structure.
Comment 1 Chris Dumez 2019-09-17 15:48:47 PDT 
Created attachment 379000 [details]
Patch
Comment 2 Chris Dumez 2019-09-17 15:52:32 PDT 
Created attachment 379001 [details]
Patch
Comment 3 Chris Dumez 2019-09-17 16:23:55 PDT 
Created attachment 379005 [details]
Patch
Comment 4 Alex Christensen 2019-09-17 17:39:07 PDT 
Comment on attachment 379005 [details]
Patch

http://trac.webkit.org/r250006
Comment 5 Radar WebKit Bug Importer 2019-09-17 17:40:29 PDT 
<rdar://problem/55461391>
Comment 6 Chris Dumez 2019-09-17 18:43:39 PDT 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 379005 [details]
> Patch
> 
> http://trac.webkit.org/r250006

Come on Alex!
<https://trac.webkit.org/changeset/250018> :P
Comment 7 Alex Christensen 2019-09-17 19:25:45 PDT 
:(
Thanks for the build fix.