RESOLVED FIXED Bug 201888
Stop calling Page::setSessionID() from WebKit2 
https://bugs.webkit.org/show_bug.cgi?id=201888
Summary Stop calling Page::setSessionID() from WebKit2
Chris Dumez
Reported 2019-09-17 15:45:48 PDT
Stop calling Page::setSessionID() from WebKit2 since Page's sessionID can never change when using WebKit2 (We process-swap and create a new Page in a new process when changing data store). Instead, we now pass the sessionID ID when constructing the Page, as part of the PageConfiguration structure.
Attachments
Patch (16.95 KB, patch)
2019-09-17 15:48 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.41 KB, patch)
2019-09-17 15:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.04 KB, patch)
2019-09-17 16:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-17 15:48:47 PDT
Created attachment 379000 [details] Patch
Chris Dumez
Comment 2 2019-09-17 15:52:32 PDT
Created attachment 379001 [details] Patch
Chris Dumez
Comment 3 2019-09-17 16:23:55 PDT
Created attachment 379005 [details] Patch
Alex Christensen
Comment 4 2019-09-17 17:39:07 PDT
Comment on attachment 379005 [details] Patch http://trac.webkit.org/r250006
Radar WebKit Bug Importer
Comment 5 2019-09-17 17:40:29 PDT
<rdar://problem/55461391>
Chris Dumez
Comment 6 2019-09-17 18:43:39 PDT
(In reply to Alex Christensen from comment #4) > Comment on attachment 379005 [details] > Patch > > http://trac.webkit.org/r250006 Come on Alex! <https://trac.webkit.org/changeset/250018> :P
Alex Christensen
Comment 7 2019-09-17 19:25:45 PDT
:( Thanks for the build fix.
Note You need to log in before you can comment on or make changes to this bug.