WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 201873
run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
https://bugs.webkit.org/show_bug.cgi?id=201873
Summary
run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when...
David Kilzer (:ddkilzer)
Reported
2019-09-17 09:45:25 PDT
Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test() in run-webkit-tests. This breaks traditional leaks checking (added in
Bug 193772
) and document leak checking at the end of each testing shard. (This regressed sometime after the fix for
Bug 193772
was landed. I think it was related to fixing test timeouts on bots.)
Attachments
Patch v1
(1.58 KB, patch)
2019-09-17 09:47 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-09-17 09:45:54 PDT
<
rdar://problem/55442387
>
David Kilzer (:ddkilzer)
Comment 2
2019-09-17 09:47:50 PDT
Created
attachment 378971
[details]
Patch v1
WebKit Commit Bot
Comment 3
2019-09-17 10:50:33 PDT
Comment on
attachment 378971
[details]
Patch v1 Clearing flags on attachment: 378971 Committed
r249965
: <
https://trac.webkit.org/changeset/249965
>
WebKit Commit Bot
Comment 4
2019-09-17 10:50:35 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug