Bug 201853 - CheckArray on DirectArguments/ScopedArguments does not filter out slow put array storage
Summary: CheckArray on DirectArguments/ScopedArguments does not filter out slow put ar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-16 18:22 PDT by Saam Barati
Modified: 2019-09-17 09:32 PDT (History)
14 users (show)

See Also:

Attachments
patch (4.83 KB, patch)
2019-09-16 18:29 PDT, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (4.79 KB, patch)
2019-09-16 18:50 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-09-16 18:22:12 PDT 
...
Comment 1 Saam Barati 2019-09-16 18:23:12 PDT 
<rdar://problem/53805461>
Comment 2 Saam Barati 2019-09-16 18:29:40 PDT 
Created attachment 378924 [details]
patch
Comment 3 Yusuke Suzuki 2019-09-16 18:32:14 PDT 
Comment on attachment 378924 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378924&action=review

r=me with comment.

> Source/JavaScriptCore/dfg/DFGArrayMode.h:447
> +            return arrayModesWithIndexingShapes(ArrayStorageShape, NonArray) | arrayModesWithIndexingShapes(SlowPutArrayStorageShape, NonArray);

Should we just do like, `arrayModesWithIndexingShapes(NonArray, ArrayStorageShape, SlowPutArrayStorageShape)`?
Comment 4 Saam Barati 2019-09-16 18:48:43 PDT 
Comment on attachment 378924 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378924&action=review

>> Source/JavaScriptCore/dfg/DFGArrayMode.h:447
>> +            return arrayModesWithIndexingShapes(ArrayStorageShape, NonArray) | arrayModesWithIndexingShapes(SlowPutArrayStorageShape, NonArray);
> 
> Should we just do like, `arrayModesWithIndexingShapes(NonArray, ArrayStorageShape, SlowPutArrayStorageShape)`?

yes, I meant to do that :)
Comment 5 Saam Barati 2019-09-16 18:50:13 PDT 
Created attachment 378925 [details]
patch for landing
Comment 6 WebKit Commit Bot 2019-09-17 09:32:18 PDT 
Comment on attachment 378925 [details]
patch for landing

Clearing flags on attachment: 378925

Committed r249959: <https://trac.webkit.org/changeset/249959>
Comment 7 WebKit Commit Bot 2019-09-17 09:32:20 PDT 
All reviewed patches have been landed.  Closing bug.