Bug 201850 – Wasm StreamingParser should validate that number of functions matches number of declarations

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

<rdar://problem/55290186>

[Tadeu Zagallo]

Created attachment 378916 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 378916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378916&action=review

r=me

> Source/JavaScriptCore/wasm/WasmStreamingParser.cpp:389
> +        if (m_functionCount != m_info->functions.size()) {
> +            m_state = fail("Number of functions parsed (", m_functionCount, ") does not match the number of declared functions (", m_info->functions.size(), ")");
> +            break;
> +        }

I suggest using m_functionIndex mainly for readability.

[Tadeu Zagallo]

Comment on attachment 378916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378916&action=review

Thanks for the review!

>> Source/JavaScriptCore/wasm/WasmStreamingParser.cpp:389
>> +        }
> 
> I suggest using m_functionIndex mainly for readability.

Works for me, I'll update it.

[Tadeu Zagallo]

Created attachment 378922 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 378922 [details]
Patch for landing

Clearing flags on attachment: 378922

Committed r249935: <https://trac.webkit.org/changeset/249935>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.