Bug 201846 - Make all ScriptWrappable IsoHeap-ed
Summary: Make all ScriptWrappable IsoHeap-ed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-16 15:44 PDT by Yusuke Suzuki
Modified: 2019-09-18 15:10 PDT (History)
37 users (show)

See Also:


Attachments
Patch (120.12 KB, patch)
2019-09-16 15:47 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (120.16 KB, patch)
2019-09-16 15:49 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff
Patch for landing, update for newly added Event, GPUUncapturedErrorEvent (127.00 KB, patch)
2019-09-18 03:22 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-09-16 15:44:55 PDT
Make all ScriptWrappable IsoHeap-ed
Comment 1 Yusuke Suzuki 2019-09-16 15:47:21 PDT
Created attachment 378902 [details]
Patch
Comment 2 Yusuke Suzuki 2019-09-16 15:49:01 PDT
Created attachment 378903 [details]
Patch
Comment 3 Yusuke Suzuki 2019-09-16 15:53:48 PDT
Note that this does not cause Speedometer2 regression.
Comment 4 Mark Lam 2019-09-16 16:30:46 PDT
Comment on attachment 378903 [details]
Patch

r=me
Comment 5 Yusuke Suzuki 2019-09-16 16:34:27 PDT
I'll land this after I recheck this super carefully, and after I run the LLDB-based test to ensure the invariant.
Comment 6 Yusuke Suzuki 2019-09-18 03:22:16 PDT
Created attachment 379031 [details]
Patch for landing, update for newly added Event, GPUUncapturedErrorEvent
Comment 7 Yusuke Suzuki 2019-09-18 03:25:53 PDT
Checked with https://bugs.webkit.org/show_bug.cgi?id=201890 's ad-hoc script. I would like to introduce such a test in a separate patch.
Comment 8 Yusuke Suzuki 2019-09-18 03:33:22 PDT
Committed r250030: <https://trac.webkit.org/changeset/250030>
Comment 9 Radar WebKit Bug Importer 2019-09-18 03:34:17 PDT
<rdar://problem/55472869>
Comment 10 Russell Epstein 2019-09-18 09:51:51 PDT
Reverted r250030 for reason:

Cause of Recent Build Failures.

Committed r250040: <https://trac.webkit.org/changeset/250040>
Comment 11 Yusuke Suzuki 2019-09-18 15:10:14 PDT
Committed r250060: <https://trac.webkit.org/changeset/250060>