Bug 201840 – AX: USER: VO: Messages > Message > Shift-VO-M doesn't reveal correct actions

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Eric Liang]

Seed user reports that in Messages, when VO cursor is focused on a message, Shift-VO-M doesn’t reveal the Tapback command (or other commands) user is presented with when they Control Click on a Message.

https://sitewatch.apple.com/watches/acker-public-seed/issues/342853

Steps To Reproduce:
1. Enable VoiceOver
2. Messages > focus VO cursor on a Message > Shift-VO-M > control click on message > control click outside of message

Results:
Shift-VO-M: only delivers ‘Clear Chat Transcript’ command. User expected Tapback command.

Regression:
Reproduced in 16C27

Notes:
What’s interesting is that the ‘Clear Chat Transcript’ command appears when Control-Click outside of message. This seems to indicate some weirdness with the focus, however, interacting with text of message doesn’t address the behavior.

[Eric Liang]

rdar://problem/28872781

[Eric Liang]

Created attachment 378892 [details]
Patch

[chris fleizach]

Comment on attachment 378892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378892&action=review

> Source/WebCore/ChangeLog:8
> +        menuForEvent: expects event-position in windowâs space, but we pass the position in Coreâs space. In this case, we need to convert coreâs space to windowâs space.

can you use ascii characters here instead of unicode

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3767
> +                ScrollView *scrollView = downcast<AccessibilityScrollView>(*parent).scrollView();

can you change this to 

auto scrollView while we're here. should probably also do

// just to ensure we have a scrollView
if (auto scrollView = ...) {

}

[Eric Liang]

Created attachment 378894 [details]
Patch

[Eric Liang]

Created attachment 378895 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 378895 [details]
Patch

Clearing flags on attachment: 378895

Committed r249930: <https://trac.webkit.org/changeset/249930>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.