Bug 201830 - NetworkProcessConnection does not need HashMaps of sessionIDs for Service Workers and IDB
Summary: NetworkProcessConnection does not need HashMaps of sessionIDs for Service Wor...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-16 12:36 PDT by Chris Dumez
Modified: 2019-09-16 21:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.00 KB, patch)
2019-09-16 12:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (17.00 KB, patch)
2019-09-16 12:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (16.94 KB, patch)
2019-09-16 12:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (16.86 KB, patch)
2019-09-16 13:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-16 12:36:05 PDT 
NetworkProcessConnection does not need HashMap of sessionIDs for Service Workers and IDB, since we now have one sessionID per WebContent process.
Comment 1 Chris Dumez 2019-09-16 12:37:10 PDT 
Created attachment 378878 [details]
Patch
Comment 2 Chris Dumez 2019-09-16 12:37:58 PDT 
Created attachment 378879 [details]
Patch
Comment 3 Chris Dumez 2019-09-16 12:47:40 PDT 
Created attachment 378880 [details]
Patch
Comment 4 Chris Dumez 2019-09-16 13:05:16 PDT 
Created attachment 378885 [details]
Patch
Comment 5 Geoffrey Garen 2019-09-16 14:05:28 PDT 
Comment on attachment 378885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378885&action=review

r=me

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:76
> +    uint64_t messageSenderDestinationID() const final { return 0; }

Are these zero accessors going to be removed in a future patch?
Comment 6 Chris Dumez 2019-09-16 14:20:19 PDT 
Comment on attachment 378885 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378885&action=review

>> Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:76
>> +    uint64_t messageSenderDestinationID() const final { return 0; }
> 
> Are these zero accessors going to be removed in a future patch?

I don't think they can. messageSenderDestinationID() is pure virtual on IPC::MessageSender so we have to provide an implementation. It is equivalent to the many send() calls we have that pass 0 as destinationID as last parameter (because there is only one destination on this IPC connection).
Comment 7 Chris Dumez 2019-09-16 14:52:10 PDT 
Comment on attachment 378885 [details]
Patch

Clearing flags on attachment: 378885

Committed r249923: <https://trac.webkit.org/changeset/249923>
Comment 8 Chris Dumez 2019-09-16 14:52:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-09-16 14:53:18 PDT 
<rdar://problem/55415603>