RESOLVED FIXED Bug 201829
SamplingProfiler should hold API lock before reporting results 
https://bugs.webkit.org/show_bug.cgi?id=201829
Summary SamplingProfiler should hold API lock before reporting results
Tadeu Zagallo
Reported 2019-09-16 11:53:06 PDT
...
Attachments
Patch (1.79 KB, patch)
2019-09-16 12:55 PDT, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2019-09-16 12:55:14 PDT
Created attachment 378882 [details] Patch
Yusuke Suzuki
Comment 2 2019-09-16 13:27:58 PDT
Comment on attachment 378882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378882&action=review r=me with nit. > Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1029 > + JSLockHolder holder(m_vm); Can you ensure that this locking order (registerationLock -> APILock) is correct? (maybe, in practice, it does not matter).
Tadeu Zagallo
Comment 3 2019-09-16 13:31:49 PDT
Thanks for the review! (In reply to Yusuke Suzuki from comment #2) > Can you ensure that this locking order (registerationLock -> APILock) is > correct? (maybe, in practice, it does not matter). The registrationLock is only guarding the append to the HashSet, `reportDataToOptionFile` is actually called later, from within the `atexit` lambda.
WebKit Commit Bot
Comment 4 2019-09-16 13:48:44 PDT
Comment on attachment 378882 [details] Patch Clearing flags on attachment: 378882 Committed r249915: <https://trac.webkit.org/changeset/249915>
WebKit Commit Bot
Comment 5 2019-09-16 13:48:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-16 13:49:26 PDT
<rdar://problem/55412906>
Note You need to log in before you can comment on or make changes to this bug.