Bug 201823 - results.webkit.org results bubbles' tooltips should include SDK information
Summary: results.webkit.org results bubbles' tooltips should include SDK information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-16 09:38 PDT by Russell Epstein
Modified: 2019-09-17 16:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.83 KB, patch)
2019-09-17 13:43 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (5.83 KB, patch)
2019-09-17 15:11 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Epstein 2019-09-16 09:38:36 PDT
Issue: 
Currently, SDK information is only shown if there are results from multiple SDKs for a given configuration. 

Impact:
SDK versions for configurations with results from only one SDK are less discoverable than configurations with results from > 1 SDK.

Improvement:
It would be helpful to include SDK information in the mouse-over tooltip for each result bubble. This would reduce time/clicks required to confirm SDK version for configurations with results from a single SDK.
Comment 1 Radar WebKit Bug Importer 2019-09-16 09:39:21 PDT
<rdar://problem/55402596>
Comment 2 Jonathan Bedard 2019-09-16 09:43:09 PDT
Actually, we should probably go farther and include any configuration bits that are shared when collapsing multiple runs into a single bubble.
Comment 3 Jonathan Bedard 2019-09-17 13:43:04 PDT
Created attachment 378984 [details]
Patch
Comment 4 Jonathan Bedard 2019-09-17 13:43:59 PDT
Deploying this to the staging instance now.

It seems like a pretty unambiguous improvement.
Comment 5 Aakash Jain 2019-09-17 14:40:11 PDT
rs=me
Comment 6 Jonathan Bedard 2019-09-17 15:11:36 PDT
Created attachment 378997 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-09-17 15:56:01 PDT
Comment on attachment 378997 [details]
Patch for landing

Rejecting attachment 378997 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 378997, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=378997&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=201823&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 378997 from bug 201823.
Fetching: https://bugs.webkit.org/attachment.cgi?id=378997
Authentication required
Authentication required
Authentication required
Updating OpenSource
Already up to date.

Full output: https://webkit-queues.webkit.org/results/13041190
Comment 8 WebKit Commit Bot 2019-09-17 16:48:55 PDT
Comment on attachment 378997 [details]
Patch for landing

Clearing flags on attachment: 378997

Committed r250001: <https://trac.webkit.org/changeset/250001>
Comment 9 WebKit Commit Bot 2019-09-17 16:48:57 PDT
All reviewed patches have been landed.  Closing bug.