Bug 201820 - Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
Summary: Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibil...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-16 08:54 PDT by Andres Gonzalez
Modified: 2019-09-17 09:46 PDT (History)
11 users (show)

See Also:


Attachments
Patch (8.99 KB, patch)
2019-09-16 09:01 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2019-09-16 08:54:56 PDT
Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
Comment 1 Andres Gonzalez 2019-09-16 09:01:43 PDT
Created attachment 378863 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-09-16 09:58:37 PDT
<rdar://problem/55403307>
Comment 3 WebKit Commit Bot 2019-09-16 10:15:38 PDT
Comment on attachment 378863 [details]
Patch

Clearing flags on attachment: 378863

Committed r249904: <https://trac.webkit.org/changeset/249904>
Comment 4 WebKit Commit Bot 2019-09-16 10:15:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2019-09-17 09:15:36 PDT
Comment on attachment 378863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378863&action=review

> Source/WebCore/ChangeLog:3
> +        Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.

What about versions of accessibility client that didn't have this change yet?
Comment 6 chris fleizach 2019-09-17 09:46:33 PDT
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 378863 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378863&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
> 
> What about versions of accessibility client that didn't have this change yet?

As long as this change gets into 13.2, we should be in lockstep