WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201818
check-webkit-style: Fix warning message for std::make_unique<typename[]>
https://bugs.webkit.org/show_bug.cgi?id=201818
Summary
check-webkit-style: Fix warning message for std::make_unique<typename[]>
David Kilzer (:ddkilzer)
Reported
2019-09-16 06:19:05 PDT
Fix warning message for std::make_unique<_typename_[]> in check-webkit-style. When writing the patch for
Bug 201804
, it was not clear from check-webkit-style output that I hand to switch from std::make_unique<uint32_t[]>(size) to WTF::makeUniqueArray<uint32_t>(size).
Attachments
Patch v1
(4.48 KB, patch)
2019-09-16 06:36 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-09-16 06:19:22 PDT
<
rdar://problem/55397921
>
David Kilzer (:ddkilzer)
Comment 2
2019-09-16 06:36:10 PDT
Created
attachment 378857
[details]
Patch v1
David Kilzer (:ddkilzer)
Comment 3
2019-09-16 09:32:31 PDT
(In reply to David Kilzer (:ddkilzer) from
comment #2
)
> Created
attachment 378857
[details]
> Patch v1
This patch can't possibly affect ios-wk2 tests. Looks like that failure was caused by a flaky test.
WebKit Commit Bot
Comment 4
2019-09-16 10:44:55 PDT
Comment on
attachment 378857
[details]
Patch v1 Clearing flags on attachment: 378857 Committed
r249906
: <
https://trac.webkit.org/changeset/249906
>
WebKit Commit Bot
Comment 5
2019-09-16 10:44:56 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug