Bug 201814 – Fix leaks in DumpRenderTree and WebKitTestRunner

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Fix leaks in DumpRenderTree and WebKitTestRunner found by clang static analyzer.

Also clean up a function signature and add CF_RETURNS_RETAINED where necessary to document behavior.

[Radar WebKit Bug Importer]

<rdar://problem/55387900>

[David Kilzer (:ddkilzer)]

Created attachment 378842 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Created attachment 378846 [details]
Patch v2

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #2)
> Created attachment 378842 [details]
> Patch v1

Apparently CGEventRelease() isn't a thing!

[Wenson Hsieh]

Comment on attachment 378846 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=378846&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:124
> +    self.didStartFormControlInteractionCallback = nil;
> +    self.didEndFormControlInteractionCallback = nil;
> +    self.didShowForcePressPreviewCallback = nil;
> +    self.didDismissForcePressPreviewCallback = nil;
> +    self.willBeginZoomingCallback = nil;
> +    self.didEndZoomingCallback = nil;
> +    self.didShowKeyboardCallback = nil;
> +    self.didHideKeyboardCallback = nil;
> +    self.didShowMenuCallback = nil;
> +    self.didHideMenuCallback = nil;
> +    self.willPresentPopoverCallback = nil;
> +    self.didDismissPopoverCallback = nil;
> +    self.didEndScrollingCallback = nil;
> +    self.rotationDidEndCallback = nil;

These should be taken care of by -resetInteractionCallbacks, no?

[David Kilzer (:ddkilzer)]

Comment on attachment 378846 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=378846&action=review

>> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:124
>> +    self.rotationDidEndCallback = nil;
> 
> These should be taken care of by -resetInteractionCallbacks, no?

Oops!  You are correct.  Will remove.

[David Kilzer (:ddkilzer)]

Created attachment 378855 [details]
Patch v3

[WebKit Commit Bot]

Comment on attachment 378855 [details]
Patch v3

Clearing flags on attachment: 378855

Committed r249901: <https://trac.webkit.org/changeset/249901>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.