RESOLVED FIXED 201809
[LFC] Always provide a containing block width value to compute* functions. 
https://bugs.webkit.org/show_bug.cgi?id=201809
Summary [LFC] Always provide a containing block width value to compute* functions.
zalan
Reported 2019-09-15 15:17:36 PDT
The only case when the containing block width might not be available is when computing the preferred width. Let's just pass in a 0 value in those cases instead of dealing with the optional cases.
Attachments
Patch (32.62 KB, patch)
2019-09-15 15:35 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (32.62 KB, patch)
2019-09-16 09:16 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-15 15:18:04 PDT
<rdar://problem/55383153>
zalan
Comment 2 2019-09-15 15:35:07 PDT
Created attachment 378825 [details] Patch
Antti Koivisto
Comment 3 2019-09-16 06:48:10 PDT
Comment on attachment 378825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378825&action=review > Source/WebCore/ChangeLog:9 > + The caller can always make a more informative decision about the default value when the continaing block width is not available. Typo 'continaing'
zalan
Comment 4 2019-09-16 09:16:20 PDT
Created attachment 378864 [details] Patch
WebKit Commit Bot
Comment 5 2019-09-16 09:56:42 PDT
Comment on attachment 378864 [details] Patch Clearing flags on attachment: 378864 Committed r249903: <https://trac.webkit.org/changeset/249903>
WebKit Commit Bot
Comment 6 2019-09-16 09:56:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.