Bug 201809 - [LFC] Always provide a containing block width value to compute* functions.
Summary: [LFC] Always provide a containing block width value to compute* functions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-15 15:17 PDT by zalan
Modified: 2019-09-16 09:56 PDT (History)
6 users (show)

See Also:


Attachments
Patch (32.62 KB, patch)
2019-09-15 15:35 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (32.62 KB, patch)
2019-09-16 09:16 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-09-15 15:17:36 PDT
The only case when the containing block width might not be available is when computing the preferred width. Let's just pass in a 0 value in those cases instead of dealing with the optional cases.
Comment 1 Radar WebKit Bug Importer 2019-09-15 15:18:04 PDT
<rdar://problem/55383153>
Comment 2 zalan 2019-09-15 15:35:07 PDT
Created attachment 378825 [details]
Patch
Comment 3 Antti Koivisto 2019-09-16 06:48:10 PDT
Comment on attachment 378825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378825&action=review

> Source/WebCore/ChangeLog:9
> +        The caller can always make a more informative decision about the default value when the continaing block width is not available.

Typo 'continaing'
Comment 4 zalan 2019-09-16 09:16:20 PDT
Created attachment 378864 [details]
Patch
Comment 5 WebKit Commit Bot 2019-09-16 09:56:42 PDT
Comment on attachment 378864 [details]
Patch

Clearing flags on attachment: 378864

Committed r249903: <https://trac.webkit.org/changeset/249903>
Comment 6 WebKit Commit Bot 2019-09-16 09:56:43 PDT
All reviewed patches have been landed.  Closing bug.