Bug 201808 – Update testharness.js from upstream

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

Update testharness.js from upstream.

[Chris Dumez]

Created attachment 378820 [details]
Patch

[EWS Watchlist]

Comment on attachment 378820 [details]
Patch

Attachment 378820 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13034569

New failing tests:
fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html
fast/css/parse-justify-self.html
fast/events/clipboard-event-constructor.html
fast/shadow-dom/stylesheet-title-in-shadow-tree.html
js/promises-tests/promises-in-workers.html
fast/css/DOMQuad-serialization.html
fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html
fast/shadow-dom/event-path-with-window.html
http/tests/fetch/redirectmode-and-preload.html
imported/blink/editing/selection/selectstart-event-crash.html
fast/shadow-dom/slotchange-for-slot-mutation.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html
fast/shadow-dom/offsetParent-across-shadow-boundaries.html
fast/css/Element-style.html
css3/flexbox/style-change.html

[EWS Watchlist]

Created attachment 378822 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Chris Dumez]

Created attachment 378823 [details]
Patch

[Chris Dumez]

Created attachment 378824 [details]
Patch

[Chris Dumez]

Created attachment 378826 [details]
Patch

[Chris Dumez]

Created attachment 378830 [details]
Patch

[EWS Watchlist]

Comment on attachment 378830 [details]
Patch

Attachment 378830 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13034916

New failing tests:
streams/readable-byte-stream-controller-worker.html
streams/readable-stream-byob-reader-worker.html
streams/readable-stream-byob-request-worker.html

[EWS Watchlist]

Created attachment 378832 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Chris Dumez]

Created attachment 378833 [details]
Patch

[Darin Adler]

Comment on attachment 378833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378833&action=review

Mostly just a rubber stamp of the idea of doing this, but a couple comments.

> LayoutTests/fast/events/clipboard-event-constructor.html:64
> +}, "bubbles / cancelabble / composed members");

Typo here, only one "b" in "cancelable".

> LayoutTests/fast/mediastream/captureStream/canvas2d-expected.txt:4
> -PASS captureStream cloning 
> +FAIL captureStream cloning assert_array_equals: property 5, expected 127 but got 128

Do we have to change this, since we are putting a test expectation in for this test?

[Chris Dumez]

(In reply to Darin Adler from comment #11)
> Comment on attachment 378833 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378833&action=review
> 
> Mostly just a rubber stamp of the idea of doing this, but a couple comments.
> 
> > LayoutTests/fast/events/clipboard-event-constructor.html:64
> > +}, "bubbles / cancelabble / composed members");
> 
> Typo here, only one "b" in "cancelable".

Ah, oops, my macBookPro keyboard has been having trouble with the 'b' key :/

> 
> > LayoutTests/fast/mediastream/captureStream/canvas2d-expected.txt:4
> > -PASS captureStream cloning 
> > +FAIL captureStream cloning assert_array_equals: property 5, expected 127 but got 128
> 
> Do we have to change this, since we are putting a test expectation in for
> this test?

You're right, I'll revert.

[Chris Dumez]

Created attachment 378884 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 378884 [details]
Patch

Clearing flags on attachment: 378884

Committed r249918: <https://trac.webkit.org/changeset/249918>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55413591>

[Truitt Savell]

It looks like the new css-dark-mode/ test are failing on Mojave from https://trac.webkit.org/changeset/249918/webkit

results:
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r249923%20(6685)/results.html

[Chris Dumez]

(In reply to Truitt Savell from comment #17)
> It looks like the new css-dark-mode/ test are failing on Mojave from
> https://trac.webkit.org/changeset/249918/webkit
> 
> results:
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/
> r249923%20(6685)/results.html

Fixed in <https://trac.webkit.org/changeset/249929>.