WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 201802
[WebIDL] Derived dictionaries should inherit their inherited dictionaries' partials
https://bugs.webkit.org/show_bug.cgi?id=201802
Summary
[WebIDL] Derived dictionaries should inherit their inherited dictionaries' pa...
Andy Estes
Reported
2019-09-14 21:47:15 PDT
[WebIDL] Derived dictionaries should inherit their inherited dictionaries' partials
Attachments
Patch
(49.71 KB, patch)
2019-09-14 21:52 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Patch
(49.72 KB, patch)
2019-09-15 16:55 PDT
,
Andy Estes
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2019-09-14 21:52:21 PDT
Created
attachment 378806
[details]
Patch
WebKit Commit Bot
Comment 2
2019-09-15 10:37:31 PDT
Comment hidden (obsolete)
Comment on
attachment 378806
[details]
Patch Rejecting
attachment 378806
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 378806, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as
commit-queue@webkit.org
... Fetching:
https://bugs.webkit.org/attachment.cgi?id=378806&action=edit
Fetching:
https://bugs.webkit.org/show_bug.cgi?id=201802
&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 378806 from
bug 201802
. Fetching:
https://bugs.webkit.org/attachment.cgi?id=378806
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to
http://svn.webkit.org/repository/webkit/trunk
... A Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary.h A Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary.h A Source/WebCore/bindings/scripts/test/TestDerivedDictionary.idl A Source/WebCore/bindings/scripts/test/TestInheritedDictionary.idl M Source/WebCore/ChangeLog M Source/WebCore/bindings/scripts/CodeGenerator.pm M Source/WebCore/bindings/scripts/generate-bindings.pl M Source/WebCore/bindings/scripts/test/TestSupplemental.idl ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Source/WebCore/bindings/scripts/test/TestDerivedDictionary.idl trunk/Source/WebCore/bindings/scripts/test/TestInheritedDictionary.idl Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: dfcd42fbba38e4302cf6da05bde5637e369ba460 and refs/remotes/origin/master differ, using rebase: :040000 040000 56d84cb2e627ab3473e91febde37698f2885ee47 9f18933f4bc23bd96982997c912716817c1e5c94 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to
http://svn.webkit.org/repository/webkit/trunk
... A Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestDerivedDictionary.h A Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestInheritedDictionary.h A Source/WebCore/bindings/scripts/test/TestDerivedDictionary.idl A Source/WebCore/bindings/scripts/test/TestInheritedDictionary.idl M Source/WebCore/ChangeLog M Source/WebCore/bindings/scripts/CodeGenerator.pm M Source/WebCore/bindings/scripts/generate-bindings.pl M Source/WebCore/bindings/scripts/test/TestSupplemental.idl ERROR from SVN: A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/Source/WebCore/bindings/scripts/test/TestDerivedDictionary.idl trunk/Source/WebCore/bindings/scripts/test/TestInheritedDictionary.idl Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. W: dfcd42fbba38e4302cf6da05bde5637e369ba460 and refs/remotes/origin/master differ, using rebase: :040000 040000 56d84cb2e627ab3473e91febde37698f2885ee47 9f18933f4bc23bd96982997c912716817c1e5c94 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output:
https://webkit-queues.webkit.org/results/13034280
Andy Estes
Comment 3
2019-09-15 16:55:04 PDT
Created
attachment 378831
[details]
Patch
WebKit Commit Bot
Comment 4
2019-09-15 17:41:13 PDT
Comment on
attachment 378831
[details]
Patch Clearing flags on attachment: 378831 Committed
r249888
: <
https://trac.webkit.org/changeset/249888
>
WebKit Commit Bot
Comment 5
2019-09-15 17:41:15 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-09-15 17:42:17 PDT
<
rdar://problem/55384397
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug