Bug 201801 – [Cocoa] Add a WKA extension point

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Cocoa] Add a WKA extension point

[Andy Estes]

Created attachment 378804 [details]
Patch

[Andy Estes]

rdar://problem/55372507

[Radar WebKit Bug Importer]

<rdar://problem/55372554>

[Sam Weinig]

Comment on attachment 378804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378804&action=review

> Source/WebCore/ChangeLog:3
> +        [Cocoa] Add a WKA extension point

What is a WKA extension point? Why should we add one?

> Source/WebCore/ChangeLog:11
> +        * Modules/applepay/ApplePayRequestBase.cpp:
> +        (WebCore::requiresSupportedNetworks):
> +        (WebCore::convertAndValidate):

How is this being tested?

[Andy Estes]

(In reply to Sam Weinig from comment #4)
> Comment on attachment 378804 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378804&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Cocoa] Add a WKA extension point
> 
> What is a WKA extension point? Why should we add one?

It's a place where WebKitAdditions can extend WebKit. The radar explains why we should add one.

> 
> > Source/WebCore/ChangeLog:11
> > +        * Modules/applepay/ApplePayRequestBase.cpp:
> > +        (WebCore::requiresSupportedNetworks):
> > +        (WebCore::convertAndValidate):
> 
> How is this being tested?

With a layout test, but it can't be included in this patch. It'll be part of a future patch that moves things from WebKitAdditions to open source.

[WebKit Commit Bot]

Comment on attachment 378804 [details]
Patch

Clearing flags on attachment: 378804

Committed r249964: <https://trac.webkit.org/changeset/249964>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andy Estes]

Rolled out in r249967: <https://trac.webkit.org/changeset/249967>

[Andy Estes]

Committed r250026: <https://trac.webkit.org/changeset/250026>