Bug 201801 - [Cocoa] Add a WKA extension point
Summary: [Cocoa] Add a WKA extension point
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-14 18:32 PDT by Andy Estes
Modified: 2019-09-18 00:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2019-09-14 18:34 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2019-09-14 18:32:49 PDT 
[Cocoa] Add a WKA extension point
Comment 1 Andy Estes 2019-09-14 18:34:31 PDT 
Created attachment 378804 [details]
Patch
Comment 2 Andy Estes 2019-09-14 18:34:53 PDT 
rdar://problem/55372507
Comment 3 Radar WebKit Bug Importer 2019-09-14 18:35:13 PDT 
<rdar://problem/55372554>
Comment 4 Sam Weinig 2019-09-14 18:43:24 PDT 
Comment on attachment 378804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378804&action=review

> Source/WebCore/ChangeLog:3
> +        [Cocoa] Add a WKA extension point

What is a WKA extension point? Why should we add one?

> Source/WebCore/ChangeLog:11
> +        * Modules/applepay/ApplePayRequestBase.cpp:
> +        (WebCore::requiresSupportedNetworks):
> +        (WebCore::convertAndValidate):

How is this being tested?
Comment 5 Andy Estes 2019-09-17 10:12:27 PDT 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 378804 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378804&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Cocoa] Add a WKA extension point
> 
> What is a WKA extension point? Why should we add one?

It's a place where WebKitAdditions can extend WebKit. The radar explains why we should add one.

> 
> > Source/WebCore/ChangeLog:11
> > +        * Modules/applepay/ApplePayRequestBase.cpp:
> > +        (WebCore::requiresSupportedNetworks):
> > +        (WebCore::convertAndValidate):
> 
> How is this being tested?

With a layout test, but it can't be included in this patch. It'll be part of a future patch that moves things from WebKitAdditions to open source.
Comment 6 WebKit Commit Bot 2019-09-17 10:46:10 PDT 
Comment on attachment 378804 [details]
Patch

Clearing flags on attachment: 378804

Committed r249964: <https://trac.webkit.org/changeset/249964>
Comment 7 WebKit Commit Bot 2019-09-17 10:46:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Andy Estes 2019-09-17 11:12:48 PDT 
Rolled out in r249967: <https://trac.webkit.org/changeset/249967>
Comment 9 Andy Estes 2019-09-18 00:16:17 PDT 
Committed r250026: <https://trac.webkit.org/changeset/250026>