Bug 201781 – Remove unneeded PLATFORM(*) macros in Platform.h

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Jonathan Bedard]

As per discussions in https://bugs.webkit.org/show_bug.cgi?id=201777, there are a number of PLATFORM macros in Platform.h that are made obsolete by the version macros. We should remove them.

[Jonathan Bedard]

Maybe the problem here is actually that we need to rename the __IPHONE_OS_VERSION_MIN_REQUIRED to something like '__IOS_FAMILY_OS_VERSION_MIN_REQUIRED'

[Alexey Proskuryakov]

> we need to rename the __IPHONE_OS_VERSION_MIN_REQUIRED

This one is not ours, it comes from system frameworks.

[Tim Horton]

What we really need is the thing Keith proposed offline to make this all way less complicated. Hopefully he can repeat that here.

[Keith Rollin]

I'm doing a lot of work in this area, Jonathan. I'm not exactly sure what this bugzilla covers. Let's meet up and make sure we're not duplicating our efforts.

[Keith Rollin]

As for what Tim mentions, see <rdar://problem/50220520>. I want to follow-up on those ideas once we clean up exactly what should be enabled on which platform.

[Jonathan Bedard]

(In reply to Keith Rollin from comment #4)
> I'm doing a lot of work in this area, Jonathan. I'm not exactly sure what
> this bugzilla covers. Let's meet up and make sure we're not duplicating our
> efforts.

I'm not exactly sure what this bug covers either. I was just trying to track some comments that Alexey made in <https://bugs.webkit.org/show_bug.cgi?id=201777>.

I'm fine with shelving any work here until you're finished with your patch, it seems like you have a more coherent understanding of what we want.

[Alexey Proskuryakov]

Probably best to close this bug to avoid confusion.

My comment was about how it would be most correct to have separate HAVE_ACCESSIBILITY_BUNDLES_PATH and USE_ACCESSIBILITY_BUNDLES_PATH macros. But that gets dangerously close to over-engineering.

Another of my comments was about how there are still many suspiciously looking uses of PLATFORM(IOS_FAMILY) with iOS specific version checks. Those may or may mean that the #ifs were meant to enable something on a different set of targets.