Bug 201779 – results.webkit.org: Collapse results with the same version name

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

If a result has the same version name, and a different version number, we should collapse them the same way we do with differing SDKs.

[Jonathan Bedard]

Created attachment 378757 [details]
Patch

[Jonathan Bedard]

Not entirely convinced this is the right change, adding bot watchers for input.

[Jonathan Bedard]

Created attachment 379007 [details]
Patch

[Jonathan Bedard]

This change differentiates between E releases, even if they share a version name.

[Jonathan Bedard]

Created attachment 379036 [details]
Patch

[Jonathan Bedard]

Created attachment 379044 [details]
Patch

[Aakash Jain]

Comment on attachment 379044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379044&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:121
> +                    this.version_name = `${this.version_name}\u200B\u200B`;

Is there another cleaner way we can implement this without adding these unicode characters? 

if not: 
a) please make these unicode characters a variable
b) instead of hard-coding '-2', use len() of that variable 
c) worth adding a comment to explain why we are adding these unicode characters.

> Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:212
> +        const myMatch = this.sdk.match(SDK_REGEX);

these variable names (myMatch, otherMatch) can be improved.

[Jonathan Bedard]

Comment on attachment 379044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379044&action=review

>> Tools/resultsdbpy/resultsdbpy/view/static/js/configuration.js:121
>> +                    this.version_name = `${this.version_name}\u200B\u200B`;
> 
> Is there another cleaner way we can implement this without adding these unicode characters? 
> 
> if not: 
> a) please make these unicode characters a variable
> b) instead of hard-coding '-2', use len() of that variable 
> c) worth adding a comment to explain why we are adding these unicode characters.

I was debating between this and just checking if the string end with ' E'....Upon further reflection, I think checking for the ' E' will be cleaner,

[Jonathan Bedard]

Created attachment 379164 [details]
Patch

[Aakash Jain]

rs=me

[Jonathan Bedard]

Created attachment 379177 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 379177 [details]
Patch for landing

Clearing flags on attachment: 379177

Committed r250113: <https://trac.webkit.org/changeset/250113>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55542444>

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 379384 [details]
Patch

[Aakash Jain]

rs=me

[Jonathan Bedard]

Created attachment 379385 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 379385 [details]
Patch for landing

Clearing flags on attachment: 379385

Committed r250251: <https://trac.webkit.org/changeset/250251>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.