Bug 201774 - We should never fail to allocate VA for the Gigacage.
Summary: We should never fail to allocate VA for the Gigacage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-13 14:20 PDT by Mark Lam
Modified: 2019-09-13 15:07 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (1.90 KB, patch)
2019-09-13 14:25 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-09-13 14:20:04 PDT 
Unfortunately, this is still not true for OS(LINUX).  So, I'll leave the GIGACAGE_ALLOCATION_CAN_FAIL code in place but disable it for everything else.

<rdar://problem/55352042>
Comment 1 Mark Lam 2019-09-13 14:25:07 PDT 
Created attachment 378753 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2019-09-13 14:26:55 PDT 
Comment on attachment 378753 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2019-09-13 15:07:34 PDT 
Thanks for the review.  Landed in r249856: <http://trac.webkit.org/r249856>.