Bug 20176 - querySelectorAll id optimization no longer working
: querySelectorAll id optimization no longer working
Status: RESOLVED FIXED
: WebKit
HTML DOM
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-07-25 17:00 PST by
Modified: 2008-07-27 15:06 PST (History)


Attachments
Patch; Passes run-webkit-tests and doesn't regress http://ejohn.org/apps/selectortest/#target (2.40 KB, patch)
2008-07-25 17:06 PST, David Smith
sam: review-
Review Patch | Details | Formatted Diff | Diff
patch (12.22 KB, patch)
2008-07-27 14:55 PST, Sam Weinig
oliver: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-07-25 17:00:02 PST
Regresses the time for the #speech5 test on webkit.org/perf/slickspeed from 1-3ms to 10-12+ ms.
------- Comment #1 From 2008-07-25 17:06:07 PST -------
Created an attachment (id=22488) [details]
Patch; Passes run-webkit-tests and doesn't regress http://ejohn.org/apps/selectortest/#target
------- Comment #2 From 2008-07-26 22:41:41 PST -------
(From update of attachment 22488 [details])
Looks good.
------- Comment #3 From 2008-07-26 22:51:03 PST -------
(From update of attachment 22488 [details])
The check shouldn't be necessary, and can be made an ASSERT as far as I can tell.  It should also read querySelector->m_attr== idAttr, not querySelector->m_attr.localName() == idAttr.

I believe this will also break some uses of querySelector("#camalCase"); in quirks mode.  We probably need to disable the optimization in quirks mode methinks.
------- Comment #4 From 2008-07-27 14:55:26 PST -------
Created an attachment (id=22511) [details]
patch
------- Comment #5 From 2008-07-27 15:06:39 PST -------
Fixed in r35406.