Re-sync HTML web-platform-tests from upstream.
Created attachment 378709 [details] Patch
Created attachment 378711 [details] Patch
Created attachment 378713 [details] Patch
Created attachment 378733 [details] Patch
Created attachment 378745 [details] Patch
Comment on attachment 378745 [details] Patch Patch is ready for review.
Patch is too big for me to r+ it... r=me anyway. Two things to note: 1. There are several tests that use {{domains[www1]}}. Instead, we should migrate these tests to {{hosts[alt][]}} as long as they do not care about domain hierarchy which seems to be the case. Would be great to do that as a follow-up and upstream these changes to WPT (there is a GitHub issue on that). 2.We should probably not import imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers This can be skipped by updating LayoutTests/imported/w3c/resources/import-expectations.json.
Created attachment 378815 [details] Patch
Created attachment 378818 [details] Patch
Comment on attachment 378815 [details] Patch Clearing flags on attachment: 378815 Committed r249886: <https://trac.webkit.org/changeset/249886>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55381542>
It looks like this change in https://trac.webkit.org/changeset/249886/webkit has broken 3 of the modified tests on Mac: imported/w3c/web-platform-tests/html/browsers/offline/application-cache-api/api_update.https.html imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/video-controls-vertical-writing-mode.html imported/w3c/web-platform-tests/html/browsers/offline/application-cache-api/api_swapcache_error.https.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Foffline%2Fapplication-cache-api%2Fapi_update.https.html%20imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Frendering%2Freplaced-elements%2Fembedded-content%2Fvideo-controls-vertical-writing-mode.html%20imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Foffline%2Fapplication-cache-api%2Fapi_swapcache_error.https.html
Multiple others failing too: imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin_2.html imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html
(In reply to Truitt Savell from comment #14) > Multiple others failing too: > > imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history- > traversal/browsing_context_name_cross_origin_2.html > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > element/module/import-meta/import-meta-url.html Will look into it. But EWS was green so these tests could be flaky or need platform-specific expectations
It doesnt look like ews ran to completion for the last patch posted.
(In reply to Chris Dumez from comment #15) > (In reply to Truitt Savell from comment #14) > > Multiple others failing too: > > > > imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history- > > traversal/browsing_context_name_cross_origin_2.html > > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > > element/module/import-meta/import-meta-url.html > > Will look into it. But EWS was green so these tests could be flaky or need > platform-specific expectations First follow-up: <https://trac.webkit.org/changeset/249896>
(In reply to Truitt Savell from comment #16) > It doesnt look like ews ran to completion for the last patch posted. The last patch posted removed tests.
(In reply to Chris Dumez from comment #17) > (In reply to Chris Dumez from comment #15) > > (In reply to Truitt Savell from comment #14) > > > Multiple others failing too: > > > > > > imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history- > > > traversal/browsing_context_name_cross_origin_2.html > > > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > > > element/module/import-meta/import-meta-url.html > > > > Will look into it. But EWS was green so these tests could be flaky or need > > platform-specific expectations > > First follow-up: > <https://trac.webkit.org/changeset/249896> Second follow-up: <https://trac.webkit.org/changeset/249897>
(In reply to Chris Dumez from comment #19) > (In reply to Chris Dumez from comment #17) > > (In reply to Chris Dumez from comment #15) > > > (In reply to Truitt Savell from comment #14) > > > > Multiple others failing too: > > > > > > > > imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history- > > > > traversal/browsing_context_name_cross_origin_2.html > > > > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > > > > element/module/import-meta/import-meta-url.html > > > > > > Will look into it. But EWS was green so these tests could be flaky or need > > > platform-specific expectations > > > > First follow-up: > > <https://trac.webkit.org/changeset/249896> > > Second follow-up: > <https://trac.webkit.org/changeset/249897> Follow-up: <https://trac.webkit.org/changeset/249898>
(In reply to Truitt Savell from comment #14) > Multiple others failing too: > > imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history- > traversal/browsing_context_name_cross_origin_2.html > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > element/module/import-meta/import-meta-url.html Would help to get links to the failures...
Follow-up: <https://trac.webkit.org/changeset/249899>
(In reply to Chris Dumez from comment #21) > (In reply to Truitt Savell from comment #14) > > Multiple others failing too: > > > > imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history- > > traversal/browsing_context_name_cross_origin_2.html > > imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script- > > element/module/import-meta/import-meta-url.html > > Would help to get links to the failures... imported/w3c/web-platform-tests/html/browsers/offline/application-cache-api/api_update.https.html Crash on Mojave leaks and wk2: no crash log found failures on other Mac queues: //build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r249894%20(15585)/imported/w3c/web-platform-tests/html/browsers/offline/application-cache-api/api_update.https-diff.txt imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/video-controls-vertical-writing-mode.html Image failure on Mac release: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/r249894%20(15585)/imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/video-controls-vertical-writing-mode-diffs.html Crash on Mac debug: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r249894%20(10900)/imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/video-controls-vertical-writing-mode-crash-log.txt imported/w3c/web-platform-tests/html/browsers/offline/application-cache-api/api_swapcache_error.https.html Crashing on Mac Debug: may have been skipped previously: https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r249894%20(9489)/imported/w3c/web-platform-tests/html/browsers/offline/application-cache-api/api_swapcache_error.https-crash-log.txt missing results, no expected file maybe?
I hopefully took care of all failures as of r249899. If some failures remain after r249899, please let me know and I'll do some more gardening.