Bug 201752 – Expose misspelling ranges for editable content to accessibility clients.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Expose misspelling ranges for editable content to accessibility clients.

[Andres Gonzalez]

Created attachment 378708 [details]
Patch

[EWS Watchlist]

Comment on attachment 378708 [details]
Patch

Attachment 378708 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13028096

New failing tests:
accessibility/misspelling-range.html
css3/filters/blur-various-radii.html

[EWS Watchlist]

Created attachment 378715 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[chris fleizach]

Comment on attachment 378708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378708&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:490
> +    // So iterate forward or bakcwars depending on the desired search

backwards

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2658
> +- (NSArray *)misspellingTextMarkerRange:(NSArray *)startTextMarkerRange direction:(NSString *)direction

I feel like we should use a boolean for the direction rather than a string which is not well defined. easier to make a mistake with that kind of parameter. what do you think?

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4250
> +        auto misspellingRange = m_object->getMisspellingRange(criteria.first, criteria.second);

we can save a line here by doing

if (auto misspellingRange = m_object->getMisspellingRange(criteria.first, criteria.second))
   return [self textMarkerRangeFromRange:misspellingRange];

[Andres Gonzalez]

Created attachment 378729 [details]
Patch

[Andres Gonzalez]

Created attachment 378750 [details]
Patch

[Andres Gonzalez]

Last upload adds fix for other platform builds.

[Andres Gonzalez]

Created attachment 378816 [details]
Patch

[Andres Gonzalez]

Last upload fixes LayoutTest for WK1.

[Andres Gonzalez]

Created attachment 378834 [details]
Patch

[chris fleizach]

Looks like we have WebKit1 layout test issues (DRT)

+CONSOLE MESSAGE: line 41: TypeError: text.misspellingTextMarkerRange is not a function. (In 'text.misspellingTextMarkerRange(startRange, true)', 'text.misspellingTextMarkerRange' is undefined)

[WebKit Commit Bot]

Comment on attachment 378834 [details]
Patch

Clearing flags on attachment: 378834

Committed r249893: <https://trac.webkit.org/changeset/249893>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55392178>