SSIA.
Created attachment 378707 [details] Patch
Created attachment 378770 [details] Patch
Created attachment 378774 [details] Patch
Created attachment 378783 [details] Patch
Comment on attachment 378783 [details] Patch Rejecting attachment 378783 [details] from commit-queue. changseok@webkit.org does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
(In reply to ews-feeder from comment #5) > Comment on attachment 378783 [details] > Patch > > Rejecting attachment 378783 [details] from commit-queue. > > changseok@webkit.org does not have committer permissions according to > https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/ > contributors.json. > > - If you do not have committer rights please read > http://webkit.org/coding/contributing.html for instructions on how to use > bugzilla flags. > > - If you have committer rights please correct the error in > Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to > the file (no review needed). The commit-queue restarts itself every 2 > hours. After restart the commit-queue will correctly respect your committer > rights. I forgot to lose my committership. Could anyone set cq+ instead?
(In reply to ChangSeok Oh from comment #6) > (In reply to ews-feeder from comment #5) > > Comment on attachment 378783 [details] > > Patch > > > > [...] > > I forgot to lose my committership. Could anyone set cq+ instead? Done! Feel free to CC or ping me if you need cq+ for some other patches.
Comment on attachment 378783 [details] Patch Clearing flags on attachment: 378783 Committed r249909: <https://trac.webkit.org/changeset/249909>
All reviewed patches have been landed. Closing bug.
(In reply to Adrian Perez from comment #7) > (In reply to ChangSeok Oh from comment #6) > > (In reply to ews-feeder from comment #5) > > > Comment on attachment 378783 [details] > > > Patch > > > > > > [...] > > > > I forgot to lose my committership. Could anyone set cq+ instead? > > Done! Feel free to CC or ping me if you need cq+ for some other patches. O.K. Thanks!