Bug 201738 - Link mediaDataLoadsAutomatically setting to AutoplayPolicy
Summary: Link mediaDataLoadsAutomatically setting to AutoplayPolicy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-12 13:35 PDT by Jer Noble
Modified: 2019-11-13 16:25 PST (History)
13 users (show)

See Also:


Attachments
Patch (10.39 KB, patch)
2019-09-23 13:40 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (10.52 KB, patch)
2019-09-27 14:11 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (11.11 KB, patch)
2019-11-13 14:15 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-09-12 13:35:04 PDT
Link mediaDataLoadsAutomatically setting to AutoplayPolicy
Comment 1 Radar WebKit Bug Importer 2019-09-12 13:35:32 PDT
<rdar://problem/55315194>
Comment 2 Jer Noble 2019-09-23 13:40:40 PDT
Created attachment 379390 [details]
Patch
Comment 3 Eric Carlson 2019-09-23 13:58:18 PDT
Comment on attachment 379390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379390&action=review

> Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7
> +

Nit: extra blank line.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575
> +    TestWebKitAPI::Util::run(&receivedLoadedEvent);

Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here?
Comment 4 Jer Noble 2019-09-23 15:12:01 PDT
(In reply to Eric Carlson from comment #3)
> Comment on attachment 379390 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379390&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7
> > +
> 
> Nit: extra blank line.
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575
> > +    TestWebKitAPI::Util::run(&receivedLoadedEvent);
> 
> Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here?

I don't really need one here; run(...) will spin until the value passed in turns true, so an explicit EXPECT_TRUE will be superfluous.
Comment 5 Jer Noble 2019-09-27 14:11:18 PDT
Created attachment 379764 [details]
Patch for landing
Comment 6 Jer Noble 2019-11-13 14:15:02 PST
Created attachment 383497 [details]
Patch
Comment 7 WebKit Commit Bot 2019-11-13 16:25:34 PST
Comment on attachment 383497 [details]
Patch

Clearing flags on attachment: 383497

Committed r252438: <https://trac.webkit.org/changeset/252438>
Comment 8 WebKit Commit Bot 2019-11-13 16:25:36 PST
All reviewed patches have been landed.  Closing bug.