Link mediaDataLoadsAutomatically setting to AutoplayPolicy
<rdar://problem/55315194>
Created attachment 379390 [details] Patch
Comment on attachment 379390 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379390&action=review > Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7 > + Nit: extra blank line. > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575 > + TestWebKitAPI::Util::run(&receivedLoadedEvent); Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here?
(In reply to Eric Carlson from comment #3) > Comment on attachment 379390 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379390&action=review > > > Tools/TestWebKitAPI/Tests/WebKit/media-loading.html:7 > > + > > Nit: extra blank line. > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:575 > > + TestWebKitAPI::Util::run(&receivedLoadedEvent); > > Don't you want a "EXPECT_TRUE(receivedLoadedEvent);" here? I don't really need one here; run(...) will spin until the value passed in turns true, so an explicit EXPECT_TRUE will be superfluous.
Created attachment 379764 [details] Patch for landing
Created attachment 383497 [details] Patch
Comment on attachment 383497 [details] Patch Clearing flags on attachment: 383497 Committed r252438: <https://trac.webkit.org/changeset/252438>
All reviewed patches have been landed. Closing bug.