Bug 201732 - REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data
Summary: REGRESSION: Web Inspector: Layout Timeline View does not show popover for ini...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-12 12:19 PDT by Joseph Pecoraro
Modified: 2019-09-13 12:03 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.64 KB, patch)
2019-09-12 12:20 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-09-12 12:19:38 PDT 
Web Inspector: Layout Timeline View does not show popover for initiator data

Steps to Reproduce:
1. Record a timeline with forced layouts
2. Show Detail Layout and Rendering timeline
3. Select a Forced Layout row
  => expected popover, but was none. Uncaught exception.
Comment 1 Radar WebKit Bug Importer 2019-09-12 12:20:05 PDT 
<rdar://problem/55312339>
Comment 2 Joseph Pecoraro 2019-09-12 12:20:44 PDT 
Created attachment 378666 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2019-09-12 15:30:56 PDT 
Comment on attachment 378666 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378666&action=review

r=me, this is another example of why UI tests would be awesome, as well as another reason why I don't like `WI.DataGrid` :(

> Source/WebInspectorUI/ChangeLog:3
> +        REGRESSION: Web Inspector: Layout Timeline View does not show popover for initiator data

I think this was r243301.
Comment 4 WebKit Commit Bot 2019-09-13 12:03:06 PDT 
Comment on attachment 378666 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 378666

Committed r249847: <https://trac.webkit.org/changeset/249847>
Comment 5 WebKit Commit Bot 2019-09-13 12:03:07 PDT 
All reviewed patches have been landed.  Closing bug.