wx port does not show tooltips

[Kevin Watters]

The wx port's ChromeClient didn't implement the setToolTip method.

[Kevin Watters]

Created attachment 22481 [details]
implement ChromeClientWx::setToolTip

Implements ChromeClientWx::setToolTip and modifies wxWebView's mouse event handler to use EventHandler::mouseMoved instead of handleMouseMoveEvent.

[Eric Seidel (no email)]

Comment on attachment 22481 [details]
implement ChromeClientWx::setToolTip

Looks fine except for the tabs.  WebCore uses 4 spaces, not tabs.

Also, which way is the easier conversion?

+	if (!tooltip || tooltip->GetTip() != wxString(tip))
+		m_webView->SetToolTip(tip);

From wxString to String or the other way?  I'm surprised that you need the explicit wxString conversion there at all.

Since you don't have the ability to commit your own patches (yet), please upload a new patch without tabs.

Thanks!

[Kevin Watters]

Created attachment 22508 [details]
Revised tooltip support patch for the wx port.

Removed all the tabs.

Unfortunately, the explicit wxString conversion is necessary at the moment--the compiler complains about ambiguous overloads.  Perhaps a future patch could resolve this.

[Kevin Ollivier]

Landed in r35437, thanks! :)