Bug 20173 - wx port does not show tooltips
: wx port does not show tooltips
Status: RESOLVED FIXED
: WebKit
WebKit wx
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2008-07-25 14:09 PST by
Modified: 2008-07-29 22:34 PST (History)


Attachments
implement ChromeClientWx::setToolTip (1.83 KB, patch)
2008-07-25 14:12 PST, Kevin Watters
eric: review-
Review Patch | Details | Formatted Diff | Diff
Revised tooltip support patch for the wx port. (1.88 KB, patch)
2008-07-27 13:10 PST, Kevin Watters
sam: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-07-25 14:09:17 PST
The wx port's ChromeClient didn't implement the setToolTip method.
------- Comment #1 From 2008-07-25 14:12:27 PST -------
Created an attachment (id=22481) [details]
implement ChromeClientWx::setToolTip

Implements ChromeClientWx::setToolTip and modifies wxWebView's mouse event handler to use EventHandler::mouseMoved instead of handleMouseMoveEvent.
------- Comment #2 From 2008-07-26 22:52:31 PST -------
(From update of attachment 22481 [details])
Looks fine except for the tabs.  WebCore uses 4 spaces, not tabs.

Also, which way is the easier conversion?

+    if (!tooltip || tooltip->GetTip() != wxString(tip))
+        m_webView->SetToolTip(tip);

From wxString to String or the other way?  I'm surprised that you need the explicit wxString conversion there at all.

Since you don't have the ability to commit your own patches (yet), please upload a new patch without tabs.

Thanks!
------- Comment #3 From 2008-07-27 13:10:40 PST -------
Created an attachment (id=22508) [details]
Revised tooltip support patch for the wx port.

Removed all the tabs.

Unfortunately, the explicit wxString conversion is necessary at the moment--the compiler complains about ambiguous overloads.  Perhaps a future patch could resolve this.
------- Comment #4 From 2008-07-29 22:34:54 PST -------
Landed in r35437, thanks! :)