Bug 201721 – Factor out duplicated functions from HTTPParsers.cpp and HTTPHeaderField.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adrian Perez]

WebCore/loader/HTTPHeaderField.cpp and WebCore/platform/network/HTTPParsers.cpp
contain functions which duplicate functionality, namely:

  HTTPHeaderField.cpp           HTTPParsers.cpp
  ============================= =====================================
  RFC7230::isCommentText()      isCommentTextCharacter()
  RFC7230::isOBSText()          isOctetInFieldContentCharacter()
  RFC7230::isVisibleCharacter() isVisibleCharacter()
  RFC7230::isDelimiter()        isDelimiterCharacter()
  RFC7230::isTokenCharacter()   isHTTPTokenCharacter()

There are also a couple of functions in HTTPParsers.cpp which could be simplieied
by using helper function from HTTPHeaderField.cpp. For example skipWhiteSpace()
could be written in terms of skipWhile()+RFC3270::isWhitespace(); skipQuotedPair()
could use skipCharacter()+RFC7230::isQuotedPairSecondOctetValue() instead of
duplicating the list of characters that can follow the backslash in a quoted pair,
and so on.

[Adrian Perez]

Created attachment 378651 [details]
Patch

[Don Olmstead]

Comment on attachment 378651 [details]
Patch

r=me assuming bots are all green.

You sure some unit tests wouldn't be of use while you're here?

[Adrian Perez]

(In reply to Don Olmstead from comment #2)
> Comment on attachment 378651 [details]
> Patch
> 
> r=me assuming bots are all green.

Thanks Don!

> You sure some unit tests wouldn't be of use while you're here?

In patch in bug #201077 an unit test was added which calls
WebCore::isValidUserAgentHeaderValue(). That test is now
exercising the functions from the WebCore::RFC7230 namespace
as well — those are direct translations from the definitions
in the RFC, so I reckon that we do not need additional tests
for them :)

[Adrian Perez]

It's late for me today, so I will r+ tomorrow morning
instead to be able to keep an eye on the bots

[Adrian Perez]

(In reply to Adrian Perez from comment #4)
> It's late for me today, so I will r+ tomorrow morning
> instead to be able to keep an eye on the bots

I meant cq+, of course O:-)

[WebKit Commit Bot]

Comment on attachment 378651 [details]
Patch

Clearing flags on attachment: 378651

Committed r249826: <https://trac.webkit.org/changeset/249826>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55331926>