Bug 201718 – WPT importer should check META global tag in .any.js files to generate the valid .html stub files

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

WPT importer should check META global tag in .any.js files to generate the valid .html stub files

[youenn fablet]

Currently we are generating worker and window tests.
We are missing serviceworker tests.

[youenn fablet]

Created attachment 378637 [details]
Patch

[youenn fablet]

Created attachment 378642 [details]
Patch

[Jonathan Bedard]

Comment on attachment 378642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378642&action=review

> Tools/Scripts/webkitpy/w3c/test_importer.py:193
> +        self.globalToSuffix = dict([

Why not:
dict(
    window='html',
    worker='worker.html',
    dedicatedworker='worker.html',
    serviceworker='service worker.html',
)

> Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:428
> +            '/mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.html': '',

I don't see us checking test1 in this test

[Jonathan Bedard]

Just a few small changes, generally looks good.

[youenn fablet]

(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 378642 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378642&action=review
> 
> > Tools/Scripts/webkitpy/w3c/test_importer.py:193
> > +        self.globalToSuffix = dict([
> 
> Why not:
> dict(
>     window='html',
>     worker='worker.html',
>     dedicatedworker='worker.html',
>     serviceworker='service worker.html',
> )

Ok

> > Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:428
> > +            '/mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.html': '',
> 
> I don't see us checking test1 in this test

This is currently required to call the importer with mock for historical reasons.
I’ll remove this restriction in a separate patch

[Jonathan Bedard]

Comment on attachment 378642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378642&action=review

>>> Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:428
>>> +            '/mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.html': '',
>> 
>> I don't see us checking test1 in this test
> 
> This is currently required to call the importer with mock for historical reasons.
> I’ll remove this restriction in a separate patch

Looking at the code you've added, shouldn't this file generate /mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.any.html and /mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.any.worker.html?

[youenn fablet]

Created attachment 378786 [details]
Patch

[youenn fablet]

(In reply to Jonathan Bedard from comment #7)
> Comment on attachment 378642 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378642&action=review
> 
> >>> Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:428
> >>> +            '/mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.html': '',
> >> 
> >> I don't see us checking test1 in this test
> > 
> > This is currently required to call the importer with mock for historical reasons.
> > I’ll remove this restriction in a separate patch
> 
> Looking at the code you've added, shouldn't this file generate
> /mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.any.html and
> /mock-checkout/WebKitBuild/w3c-tests/csswg-tests/t/test1.any.worker.html?

We could do that if we add csswg-tests/t/test1.any.js but this is already covered by the other files.
I updated the patch to remove the need for csswg-tests/t/test1.html

[WebKit Commit Bot]

Comment on attachment 378786 [details]
Patch

Clearing flags on attachment: 378786

Committed r249870: <https://trac.webkit.org/changeset/249870>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55362927>