Bug 20171 - [XBL] Add <binding> 'element' attribute
Summary: [XBL] Add <binding> 'element' attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-25 11:34 PDT by Julien Chaffraix
Modified: 2008-07-28 14:16 PDT (History)
0 users

See Also:

Attachments
First draft (17.51 KB, patch)
2008-07-25 11:39 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Just add the 'element' attribute without the handling (3.27 KB, patch)
2008-07-28 10:10 PDT, Julien Chaffraix 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2008-07-25 11:34:25 PDT 
A way of attaching bindings is through the <binding> 'element' attribute that represents a Selector to apply to the bound document.
Comment 1 Julien Chaffraix 2008-07-25 11:39:00 PDT 
Created attachment 22475 [details]
First draft

This is a first try:

- we add the potential bindings to the bound document so that we could apply the Selector efficiently.
- the binding attachment is postponed until the document is fully parsed (that is we just have to apply the Selector once).

Comments are welcome.
Comment 2 Julien Chaffraix 2008-07-28 10:10:08 PDT 
Created attachment 22522 [details]
Just add the 'element' attribute without the handling

The approach taken was not the right one so I will just add the 'element' and postpone the 'element' handling for another bug.
Comment 3 Eric Seidel (no email) 2008-07-28 13:51:14 PDT 
Comment on attachment 22522 [details]
Just add the 'element' attribute without the handling

LGTM.
Comment 4 Julien Chaffraix 2008-07-28 14:16:33 PDT 
Landed in r35412.