WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20171
[XBL] Add <binding> 'element' attribute
https://bugs.webkit.org/show_bug.cgi?id=20171
Summary
[XBL] Add <binding> 'element' attribute
Julien Chaffraix
Reported
2008-07-25 11:34:25 PDT
A way of attaching bindings is through the <binding> 'element' attribute that represents a Selector to apply to the bound document.
Attachments
First draft
(17.51 KB, patch)
2008-07-25 11:39 PDT
,
Julien Chaffraix
no flags
Details
Formatted Diff
Diff
Just add the 'element' attribute without the handling
(3.27 KB, patch)
2008-07-28 10:10 PDT
,
Julien Chaffraix
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Julien Chaffraix
Comment 1
2008-07-25 11:39:00 PDT
Created
attachment 22475
[details]
First draft This is a first try: - we add the potential bindings to the bound document so that we could apply the Selector efficiently. - the binding attachment is postponed until the document is fully parsed (that is we just have to apply the Selector once). Comments are welcome.
Julien Chaffraix
Comment 2
2008-07-28 10:10:08 PDT
Created
attachment 22522
[details]
Just add the 'element' attribute without the handling The approach taken was not the right one so I will just add the 'element' and postpone the 'element' handling for another bug.
Eric Seidel (no email)
Comment 3
2008-07-28 13:51:14 PDT
Comment on
attachment 22522
[details]
Just add the 'element' attribute without the handling LGTM.
Julien Chaffraix
Comment 4
2008-07-28 14:16:33 PDT
Landed in
r35412
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug