RESOLVED FIXED 201709
Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 500ms 
https://bugs.webkit.org/show_bug.cgi?id=201709
Summary Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 5...
Joseph Pecoraro
Reported 2019-09-11 21:05:53 PDT
CPU: Overlay Markers for Thread views are off by 500ms Steps to Reproduce: 1. Inspect this page 2. Show Timelines tab 3. Record with CPU Timeline 4. Show CPU Timeline detail view 5. Hover over the CPU Usage graph to get markers for percentages => Dots don't match up with CPU usage
Attachments
[PATCH] Proposed Fix (1.72 KB, patch)
2019-09-11 21:18 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-11 21:06:27 PDT
<rdar://problem/55289279>
Joseph Pecoraro
Comment 2 2019-09-11 21:13:13 PDT
I believe this was a regression from r245498, when the CPUTimelineRecord's startTime was moved back by the sampling rate (500ms).
Joseph Pecoraro
Comment 3 2019-09-11 21:18:18 PDT
Created attachment 378617 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 4 2019-09-11 21:56:17 PDT
Comment on attachment 378617 [details] [PATCH] Proposed Fix r=me, nice find!
WebKit Commit Bot
Comment 5 2019-09-11 23:04:15 PDT
Comment on attachment 378617 [details] [PATCH] Proposed Fix Clearing flags on attachment: 378617 Committed r249797: <https://trac.webkit.org/changeset/249797>
WebKit Commit Bot
Comment 6 2019-09-11 23:04:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.