Bug 201709 - Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 500ms
Summary: Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 5...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-11 21:05 PDT by Joseph Pecoraro
Modified: 2019-09-11 23:04 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.72 KB, patch)
2019-09-11 21:18 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-09-11 21:05:53 PDT 
CPU: Overlay Markers for Thread views are off by 500ms

Steps to Reproduce:
1. Inspect this page
2. Show Timelines tab
3. Record with CPU Timeline
4. Show CPU Timeline detail view
5. Hover over the CPU Usage graph to get markers for percentages
  => Dots don't match up with CPU usage
Comment 1 Radar WebKit Bug Importer 2019-09-11 21:06:27 PDT 
<rdar://problem/55289279>
Comment 2 Joseph Pecoraro 2019-09-11 21:13:13 PDT 
I believe this was a regression from r245498, when the CPUTimelineRecord's startTime was moved back by the sampling rate (500ms).
Comment 3 Joseph Pecoraro 2019-09-11 21:18:18 PDT 
Created attachment 378617 [details]
[PATCH] Proposed Fix
Comment 4 Devin Rousso 2019-09-11 21:56:17 PDT 
Comment on attachment 378617 [details]
[PATCH] Proposed Fix

r=me, nice find!
Comment 5 WebKit Commit Bot 2019-09-11 23:04:15 PDT 
Comment on attachment 378617 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 378617

Committed r249797: <https://trac.webkit.org/changeset/249797>
Comment 6 WebKit Commit Bot 2019-09-11 23:04:17 PDT 
All reviewed patches have been landed.  Closing bug.