Bug 201707 - Web Inspector: Crashes when intercept response continues with original content
Summary: Web Inspector: Crashes when intercept response continues with original content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-11 19:27 PDT by Joseph Pecoraro
Modified: 2019-09-12 03:59 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.92 KB, patch)
2019-09-11 19:28 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-09-11 19:27:10 PDT 
Crashes when intercept response continues with original content

Steps to Reproduce:
1. run-webkit-tests -g inspector/network/local-resource-override-continue-response.html
  => CRASH

Notes:
• didReceiveData that was deferred is no longer valid. Copy it when deferring avoids a crash.
Comment 1 Joseph Pecoraro 2019-09-11 19:27:36 PDT 
<rdar://problem/55261857>
Comment 2 Joseph Pecoraro 2019-09-11 19:28:42 PDT 
Created attachment 378612 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2019-09-11 19:30:01 PDT 
Not sure if there is any efficient way to keep the data around, but I noticed this pattern in other places and it seems straightforward. For intercepts the inspector should always provide data anyways.
Comment 4 David Kilzer (:ddkilzer) 2019-09-12 03:14:41 PDT 
Comment on attachment 378612 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2019-09-12 03:59:16 PDT 
Comment on attachment 378612 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 378612

Committed r249805: <https://trac.webkit.org/changeset/249805>
Comment 6 WebKit Commit Bot 2019-09-12 03:59:17 PDT 
All reviewed patches have been landed.  Closing bug.