Bug 201698 - Web Inspector: [Overrides] Command-Z doesn't undo changes after page reload
Summary: Web Inspector: [Overrides] Command-Z doesn't undo changes after page reload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-11 14:28 PDT by Nikita Vasilyev
Modified: 2019-09-13 01:16 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (3.85 KB, patch)
2019-09-12 11:26 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-09-11 14:28:39 PDT
Command-Z only works until you reload the page.
Comment 1 Radar WebKit Bug Importer 2019-09-11 14:28:49 PDT
<rdar://problem/55276645>
Comment 2 Joseph Pecoraro 2019-09-12 11:14:55 PDT
The TextResourceContentView gets closed via SourcesNavigationSidebarPanel _updateMainFrameTreeElement closeAllContentViews().

Perhaps we can avoid closing these particular content views.
Comment 3 Joseph Pecoraro 2019-09-12 11:26:51 PDT
Created attachment 378662 [details]
[PATCH] Proposed Fix
Comment 4 Devin Rousso 2019-09-12 15:59:38 PDT
Comment on attachment 378662 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378662&action=review

r=me, it doesn't look like `WI.TextResourceContentView` (or any of it's superclasses) rely on the current main frame, so I think this is safe :)

> Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:289
> +        for (let i = 0; i < this._backForwardList.length; ++i) {

`for (let entry of this._backForwardList)`
Comment 5 WebKit Commit Bot 2019-09-13 01:16:04 PDT
Comment on attachment 378662 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 378662

Committed r249828: <https://trac.webkit.org/changeset/249828>
Comment 6 WebKit Commit Bot 2019-09-13 01:16:05 PDT
All reviewed patches have been landed.  Closing bug.