RESOLVED FIXED 201698
Web Inspector: [Overrides] Command-Z doesn't undo changes after page reload 
https://bugs.webkit.org/show_bug.cgi?id=201698
Summary Web Inspector: [Overrides] Command-Z doesn't undo changes after page reload
Nikita Vasilyev
Reported 2019-09-11 14:28:39 PDT
Command-Z only works until you reload the page.
Attachments
[PATCH] Proposed Fix (3.85 KB, patch)
2019-09-12 11:26 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-11 14:28:49 PDT
<rdar://problem/55276645>
Joseph Pecoraro
Comment 2 2019-09-12 11:14:55 PDT
The TextResourceContentView gets closed via SourcesNavigationSidebarPanel _updateMainFrameTreeElement closeAllContentViews(). Perhaps we can avoid closing these particular content views.
Joseph Pecoraro
Comment 3 2019-09-12 11:26:51 PDT
Created attachment 378662 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 4 2019-09-12 15:59:38 PDT
Comment on attachment 378662 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378662&action=review r=me, it doesn't look like `WI.TextResourceContentView` (or any of it's superclasses) rely on the current main frame, so I think this is safe :) > Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js:289 > + for (let i = 0; i < this._backForwardList.length; ++i) { `for (let entry of this._backForwardList)`
WebKit Commit Bot
Comment 5 2019-09-13 01:16:04 PDT
Comment on attachment 378662 [details] [PATCH] Proposed Fix Clearing flags on attachment: 378662 Committed r249828: <https://trac.webkit.org/changeset/249828>
WebKit Commit Bot
Comment 6 2019-09-13 01:16:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.