Bug 201682 - Use typed identifiers for IDB connection identifiers
Summary: Use typed identifiers for IDB connection identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-11 02:51 PDT by youenn fablet
Modified: 2019-09-12 01:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (25.29 KB, patch)
2019-09-11 02:54 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (25.34 KB, patch)
2019-09-12 00:39 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-09-11 02:51:30 PDT
Use typed identifiers for IDB connection identifiers
Comment 1 youenn fablet 2019-09-11 02:54:02 PDT
Created attachment 378550 [details]
Patch
Comment 2 Chris Dumez 2019-09-11 08:22:02 PDT
Comment on attachment 378550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378550&action=review

r=me with comments.

> Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp:114
> +    ASSERT(m_serverConnectionIdentifier.toUInt64());

This change should not be needed.

> Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp:92
> +    return IDBResourceIdentifier(IDBConnectionIdentifier { WTF::HashTableDeletedValue}, std::numeric_limits<uint64_t>::max());

Missing space before }

> Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h:46
> +using IDBConnectionIdentifier = ObjectIdentifier<IDBConnectionIdentifierType>;

Why isn't this simply using IDBConnectionIdentifier = ProcessIdentifier; ?

> Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp:97
> +    return makeObjectIdentifier<IDBConnectionIdentifierType>(1);

Could this be a valid ProcessIdentifier instead (e.g. the current process' identifier?)
Comment 3 youenn fablet 2019-09-12 00:39:35 PDT
Created attachment 378630 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-09-12 01:47:38 PDT
Comment on attachment 378630 [details]
Patch for landing

Clearing flags on attachment: 378630

Committed r249803: <https://trac.webkit.org/changeset/249803>
Comment 5 WebKit Commit Bot 2019-09-12 01:47:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-12 01:48:19 PDT
<rdar://problem/55294547>
Comment 7 Radar WebKit Bug Importer 2019-09-12 01:48:20 PDT
<rdar://problem/55294548>