Use typed identifiers for IDB connection identifiers
Created attachment 378550 [details] Patch
Comment on attachment 378550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378550&action=review r=me with comments. > Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp:114 > + ASSERT(m_serverConnectionIdentifier.toUInt64()); This change should not be needed. > Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp:92 > + return IDBResourceIdentifier(IDBConnectionIdentifier { WTF::HashTableDeletedValue}, std::numeric_limits<uint64_t>::max()); Missing space before } > Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h:46 > +using IDBConnectionIdentifier = ObjectIdentifier<IDBConnectionIdentifierType>; Why isn't this simply using IDBConnectionIdentifier = ProcessIdentifier; ? > Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp:97 > + return makeObjectIdentifier<IDBConnectionIdentifierType>(1); Could this be a valid ProcessIdentifier instead (e.g. the current process' identifier?)
Created attachment 378630 [details] Patch for landing
Comment on attachment 378630 [details] Patch for landing Clearing flags on attachment: 378630 Committed r249803: <https://trac.webkit.org/changeset/249803>
All reviewed patches have been landed. Closing bug.
<rdar://problem/55294547>
<rdar://problem/55294548>