Bug 201670 – Web Inspector: Canvas: checkerboard has too much contrast in dark mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Created attachment 378522 [details]
[Image] Screenshot of Issue

.

[Devin Rousso]

Created attachment 378525 [details]
Patch

[Devin Rousso]

Created attachment 378526 [details]
[Image] Screenshot of Issue

[Devin Rousso]

Created attachment 378527 [details]
[Image] After Patch is applied

[Timothy Hatcher]

Comment on attachment 378525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378525&action=review

> Source/WebInspectorUI/ChangeLog:10
> +        Don't force a `background-color: white;` in dark mode.

I think the right fix for this might be to keep forcing white and correct the checker color to be light, like in light mode. Most of the transparent content will be light mode content and might not look good over a dark mode checkerboard. We might need a dark mode toggle for the checkerboard.

[Devin Rousso]

Comment on attachment 378525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378525&action=review

>> Source/WebInspectorUI/ChangeLog:10
>> +        Don't force a `background-color: white;` in dark mode.
> 
> I think the right fix for this might be to keep forcing white and correct the checker color to be light, like in light mode. Most of the transparent content will be light mode content and might not look good over a dark mode checkerboard. We might need a dark mode toggle for the checkerboard.

In addition to "highlighting" transparency, the checkerboard also provides a rough idea of what the content would look like when contrasted with a light/dark background.  I don't think we want to show a light checkerboard in dark mode, as that may make it harder for developers to see the content of the canvas, especially if it was drawn for a darker background (e.g. the content is a white blob, which would contrast just fine against the page's darker background, but wouldn't be visible against a white checkerboard).

Also, it's really annoying to be in dark mode and then suddenly see some bright white content :(

Given all of this, it does make sense for us to provide some sort of toggle/setting for the checkerboard that is independent of the current color scheme.

[WebKit Commit Bot]

Comment on attachment 378525 [details]
Patch

Clearing flags on attachment: 378525

Committed r249790: <https://trac.webkit.org/changeset/249790>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55287372>

[Radar WebKit Bug Importer]

<rdar://problem/55287373>