RESOLVED DUPLICATE of bug 201902 201620
REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=201620
Summary REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-s...
Jiewen Tan
Reported 2019-09-09 16:48:55 PDT
REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-credential-create-success-u2f.https.html is failing.
Attachments
Patch (5.82 KB, patch)
2019-09-09 17:38 PDT, Jiewen Tan
no flags
Try to confirm the cause. (1.56 KB, patch)
2019-09-26 13:52 PDT, Jiewen Tan
no flags
Jiewen Tan
Comment 1 2019-09-09 16:49:10 PDT
Jiewen Tan
Comment 2 2019-09-09 17:38:11 PDT
Alex Christensen
Comment 3 2019-09-09 20:37:50 PDT
Comment on attachment 378420 [details] Patch This shouldn't change any behavior, but it does introduce an unnecessary Victor copy.
Jiewen Tan
Comment 4 2019-09-10 11:56:11 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 378420 [details] > Patch > > This shouldn't change any behavior, but it does introduce an unnecessary > Victor copy. Where?
Alex Christensen
Comment 5 2019-09-10 14:36:18 PDT
Comment on attachment 378420 [details] Patch If this does fix anything, we should definitely fix Vector to prevent other such bugs. I don't think it will fix anything though, but you're welcome to try. Please revert if it doesn't fix.
Jiewen Tan
Comment 6 2019-09-10 14:38:36 PDT
Comment on attachment 378420 [details] Patch Thanks Alex for r+ it. I will definitely keep the bug open and keep an eye on the bots.
WebKit Commit Bot
Comment 7 2019-09-10 15:28:38 PDT
Comment on attachment 378420 [details] Patch Clearing flags on attachment: 378420 Committed r249737: <https://trac.webkit.org/changeset/249737>
WebKit Commit Bot
Comment 8 2019-09-10 15:28:39 PDT
All reviewed patches have been landed. Closing bug.
Jiewen Tan
Comment 9 2019-09-10 15:35:05 PDT
Reopened for continuous monitoring bots.
Jiewen Tan
Comment 10 2019-09-11 13:59:12 PDT
(In reply to Alex Christensen from comment #5) > Comment on attachment 378420 [details] > Patch > > If this does fix anything, we should definitely fix Vector to prevent other > such bugs. I don't think it will fix anything though, but you're welcome to > try. Please revert if it doesn't fix. Believe it or not. It did fix the bots: https://results.safari.apple.com/?suite=layout-tests&test=http%2Fwpt%2Fwebauthn%2Fpublic-key-credential-create-success-u2f.https.html I will try to fix the vector issue as well then.
Chris Dumez
Comment 11 2019-09-11 14:15:05 PDT
Comment on attachment 378420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378420&action=review > Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp:102 > + memset(aaguid.data(), 0, aaguidLength); Hard to believe this would change anything indeed.
Jiewen Tan
Comment 12 2019-09-26 13:47:23 PDT
(In reply to Chris Dumez from comment #11) > Comment on attachment 378420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378420&action=review > > > Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp:102 > > + memset(aaguid.data(), 0, aaguidLength); > > Hard to believe this would change anything indeed. Still not able to reproduce the issue in my other Mac that has less memory. Will upload a patch to confirm the issue.
Jiewen Tan
Comment 13 2019-09-26 13:52:15 PDT
Created attachment 379675 [details] Try to confirm the cause.
WebKit Commit Bot
Comment 14 2019-09-26 14:36:42 PDT
Comment on attachment 379675 [details] Try to confirm the cause. Clearing flags on attachment: 379675 Committed r250397: <https://trac.webkit.org/changeset/250397>
WebKit Commit Bot
Comment 15 2019-09-26 14:36:44 PDT
All reviewed patches have been landed. Closing bug.
Jiewen Tan
Comment 16 2019-09-26 15:18:36 PDT
Reopened for continuous monitoring bots.
Jiewen Tan
Comment 17 2019-09-26 18:05:19 PDT
r250397 confirmed the issue.
Jiewen Tan
Comment 18 2019-09-26 20:09:54 PDT
I guess I need to ask bot watcher for a machine to reproduce the bug before I make any changes to Vector. From code inspection, it is really hard to even make a speculative fix.
Jiewen Tan
Comment 19 2019-09-27 13:38:34 PDT
Reverted r250397 for reason: caused failure on iOS 13 Committed r250455: <https://trac.webkit.org/changeset/250455>
Alex Christensen
Comment 20 2019-10-11 15:57:53 PDT
Jiewen Tan
Comment 21 2019-10-11 16:33:52 PDT
(In reply to Alex Christensen from comment #20) > The real fix for this is in https://bugs.webkit.org/show_bug.cgi?id=201902 It looks super cool.
Jiewen Tan
Comment 22 2019-10-15 11:08:04 PDT
*** This bug has been marked as a duplicate of bug 201902 ***
Note You need to log in before you can comment on or make changes to this bug.