Bug 201617 - [macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching
Summary: [macOS] Layering violation in AuxiliaryProcessProxy::didFinishLaunching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-09 15:36 PDT by Per Arne Vollan
Modified: 2019-10-16 14:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2019-10-04 13:40 PDT, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (7.56 KB, patch)
2019-10-07 13:43 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2019-09-09 15:36:53 PDT 
The commit <https://trac.webkit.org/changeset/249649> introduced a layering violation in AuxiliaryProcessProxy::didFinishLaunching. This can be fixed by creating a virtual method in AuxiliaryProcessProxy and override the method in the WebProcessProxy to do the work.
Comment 1 Per Arne Vollan 2019-10-04 13:40:01 PDT 
Created attachment 380249 [details]
Patch
Comment 2 Brent Fulgham 2019-10-04 15:51:43 PDT 
Comment on attachment 380249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380249&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:332
> +    bool shouldSendPendingMessage(const PendingMessage&) override;

final?
Comment 3 Per Arne Vollan 2019-10-07 13:43:45 PDT 
Created attachment 380354 [details]
Patch
Comment 4 Per Arne Vollan 2019-10-07 13:54:59 PDT 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 380249 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=380249&action=review
> 
> > Source/WebKit/UIProcess/WebProcessProxy.h:332
> > +    bool shouldSendPendingMessage(const PendingMessage&) override;
> 
> final?

Yes! Thanks for reviewing :)
Comment 5 WebKit Commit Bot 2019-10-07 15:14:53 PDT 
Comment on attachment 380354 [details]
Patch

Clearing flags on attachment: 380354

Committed r250799: <https://trac.webkit.org/changeset/250799>
Comment 6 Radar WebKit Bug Importer 2019-10-16 14:46:15 PDT 
<rdar://problem/56347784>