RESOLVED FIXED 201613
[JSC] Use metadata table to iterate specific bytecode metadata instead of propertyAccessInstructions vector 
https://bugs.webkit.org/show_bug.cgi?id=201613
Summary [JSC] Use metadata table to iterate specific bytecode metadata instead of pro...
Yusuke Suzuki
Reported 2019-09-09 14:03:34 PDT
[JSC] Use metadata table to iterate specific bytecode metadata instead of propertyAccessInstructions vector
Attachments
Patch (21.23 KB, patch)
2019-09-09 14:05 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-09-09 14:05:48 PDT
Created attachment 378407 [details] Patch
Yusuke Suzuki
Comment 2 2019-09-09 14:14:19 PDT
<rdar://problem/55170668>
Mark Lam
Comment 3 2019-09-09 14:26:32 PDT
Comment on attachment 378407 [details] Patch I like it. The code is cleaner now. r=me
Yusuke Suzuki
Comment 4 2019-09-09 14:38:22 PDT
Committed r249668: <https://trac.webkit.org/changeset/249668>
Yusuke Suzuki
Comment 5 2019-09-09 22:10:23 PDT
This is causing RAMification regression, and this is a bit pathological. The problem is that LuaJSFight's list related tests. These tests are getting more memory right now. It is because sizeof(UnlinkedCodeBlock) is changed from 256 to 240. When calculating sizeClass, we are manually adding sizeof(UnlinkedCodeBlock) to size class (256 previously). This is old code, and interestingly, this 256 size class works really well. But now, added size-class becomes 240. And this difference causes memory increase in LuaJSFight list related tests. Possible solution is adding 256 to size-class list directly, but I'm not sure about whether we should do.
Yusuke Suzuki
Comment 6 2019-09-09 22:17:25 PDT
(In reply to Yusuke Suzuki from comment #5) > This is causing RAMification regression, and this is a bit pathological. > The problem is that LuaJSFight's list related tests. These tests are getting > more memory right now. It is because sizeof(UnlinkedCodeBlock) is changed > from 256 to 240. > > When calculating sizeClass, we are manually adding sizeof(UnlinkedCodeBlock) > to size class (256 previously). This is old code, and interestingly, this > 256 size class works really well. > > But now, added size-class becomes 240. And this difference causes memory > increase in LuaJSFight list related tests. > > Possible solution is adding 256 to size-class list directly, but I'm not > sure about whether we should do. https://bugs.webkit.org/show_bug.cgi?id=201631
Note You need to log in before you can comment on or make changes to this bug.