Bug 201601 - [Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
Summary: [Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-link...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-09 00:26 PDT by Fujii Hironori
Modified: 2019-09-09 18:30 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.96 KB, patch)
2019-09-09 00:33 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-09-09 00:26:47 PDT
[Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]

clang-cl reports:

> [4452/5007] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebKitDLL.cpp.obj
> In file included from ..\..\Source\WebKitLegacy\win\WebKitDLL.cpp:27:
> ..\..\Source\WebKitLegacy\win/WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
> extern HashCountedSet<WTF::String>& gClassNameCount();
>                                     ^
> 1 warning generated.
Comment 1 Fujii Hironori 2019-09-09 00:33:46 PDT
Created attachment 378352 [details]
Patch
Comment 2 Fujii Hironori 2019-09-09 18:29:35 PDT
Comment on attachment 378352 [details]
Patch

Clearing flags on attachment: 378352

Committed r249682: <https://trac.webkit.org/changeset/249682>
Comment 3 Fujii Hironori 2019-09-09 18:29:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-09-09 18:30:18 PDT
<rdar://problem/55207200>
Comment 5 Radar WebKit Bug Importer 2019-09-09 18:30:18 PDT
<rdar://problem/55207201>