Bug 201589 - Resync service workers WPT tests from upstream
Summary: Resync service workers WPT tests from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-08 09:55 PDT by Chris Dumez
Modified: 2019-09-09 16:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (555.52 KB, patch)
2019-09-08 09:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (556.60 KB, patch)
2019-09-08 09:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (556.76 KB, patch)
2019-09-08 17:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (471.50 KB, patch)
2019-09-09 09:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (564.83 KB, patch)
2019-09-09 10:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (668.49 KB, patch)
2019-09-09 11:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (720.47 KB, patch)
2019-09-09 12:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (755.75 KB, patch)
2019-09-09 14:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-08 09:55:13 PDT 
Resync service workers WPT tests from upstream.
Comment 1 Chris Dumez 2019-09-08 09:57:54 PDT 
Created attachment 378326 [details]
Patch
Comment 2 Chris Dumez 2019-09-08 09:58:49 PDT 
Created attachment 378327 [details]
Patch
Comment 3 Chris Dumez 2019-09-08 17:11:44 PDT 
Created attachment 378340 [details]
Patch
Comment 4 youenn fablet 2019-09-08 23:16:22 PDT 
Comment on attachment 378340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378340&action=review

> LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html:-116
> -    var iframe;

These changes have been added recently as part of https://github.com/web-platform-tests/wpt/commit/2fb8797e671043fed5c21a3d3ea48944d09e09d1.
Could you add them back?
This probably just requires reverting the changes to activation.https.html, activation.https-expected.txt, detached-context.https.html and detached-context.https-expected.txt
Comment 5 Chris Dumez 2019-09-09 09:35:33 PDT 
Created attachment 378374 [details]
Patch
Comment 6 Chris Dumez 2019-09-09 10:58:15 PDT 
Created attachment 378383 [details]
Patch
Comment 7 Chris Dumez 2019-09-09 11:12:51 PDT 
Created attachment 378387 [details]
Patch
Comment 8 Chris Dumez 2019-09-09 12:23:12 PDT 
Created attachment 378393 [details]
Patch
Comment 9 Chris Dumez 2019-09-09 14:18:48 PDT 
Created attachment 378410 [details]
Patch
Comment 10 WebKit Commit Bot 2019-09-09 16:14:55 PDT 
Comment on attachment 378410 [details]
Patch

Clearing flags on attachment: 378410

Committed r249672: <https://trac.webkit.org/changeset/249672>
Comment 11 WebKit Commit Bot 2019-09-09 16:14:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-09-09 16:15:22 PDT 
<rdar://problem/55202874>
Comment 13 Radar WebKit Bug Importer 2019-09-09 16:15:26 PDT 
<rdar://problem/55202875>