Bug 201584 - [Service Workers] Drop support for registration resurrection
Summary: [Service Workers] Drop support for registration resurrection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://w3c.github.io/ServiceWorker/#...
Keywords: InRadar
Depends on:
Blocks: 201169
  Show dependency treegraph
 
Reported: 2019-09-07 17:51 PDT by Chris Dumez
Modified: 2019-09-07 22:43 PDT (History)
6 users (show)

See Also:


Attachments
Patch (36.61 KB, patch)
2019-09-07 17:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (36.22 KB, patch)
2019-09-07 18:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (37.93 KB, patch)
2019-09-07 18:57 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-09-07 17:51:53 PDT
Drop support for registration resurrection (Unregistering then quickly re-registering would resurrect the original registration instead of creating a new one). This behavior is no longer in the specification (No more "isUninstalling" flag on the registration, and the registration is removed from the "scope to registration map" right away upon unregistering).

This resurrection behavior was causing a lot of flakiness in the tests so it is likely we will be able to unskip some tests. This is also what was causing the flakiness that caused Bug 201169 to be rolled out.
Comment 1 Chris Dumez 2019-09-07 17:55:35 PDT
Created attachment 378308 [details]
Patch
Comment 2 Chris Dumez 2019-09-07 18:10:39 PDT
Created attachment 378309 [details]
Patch
Comment 3 Chris Dumez 2019-09-07 18:57:52 PDT
Created attachment 378311 [details]
Patch
Comment 4 WebKit Commit Bot 2019-09-07 22:22:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 378311 [details]:

media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-09-07 22:22:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 378311 [details]:

imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html bug 201588 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2019-09-07 22:42:57 PDT
Comment on attachment 378311 [details]
Patch

Clearing flags on attachment: 378311

Committed r249627: <https://trac.webkit.org/changeset/249627>
Comment 7 WebKit Commit Bot 2019-09-07 22:42:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-09-07 22:43:15 PDT
<rdar://problem/55155689>