Bug 201572 - [FTW] Minor cleanups to avoid crashes during web browsing
Summary: [FTW] Minor cleanups to avoid crashes during web browsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-06 20:17 PDT by Brent Fulgham
Modified: 2019-09-06 23:01 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2019-09-06 20:22 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-09-06 20:17:36 PDT 
This patch addresses two crashes seen when doing general web browsing on Amazon.com and Apple.com using the FTW build of WebKit:

1. ImageBuffer::sinkIntoImage was attempting to use a render target after WTFMoving it elsewhere.
2. ImageBuffer::copyNativeImage was not properly checking the type of the render target to make sure it was suitable for Bitmap operations.
3. BackingStoreBackendDirect2DImpl::scroll would crash if the scroll offset was outside the bounds of the current view. In that case, it would attempt to allocate a texture of zero size, which triggered a crash.
Comment 1 Brent Fulgham 2019-09-06 20:22:59 PDT 
Created attachment 378268 [details]
Patch
Comment 2 Brent Fulgham 2019-09-06 22:17:30 PDT 
Thank you for the review, ap!
Comment 3 WebKit Commit Bot 2019-09-06 22:59:45 PDT 
Comment on attachment 378268 [details]
Patch

Clearing flags on attachment: 378268

Committed r249609: <https://trac.webkit.org/changeset/249609>
Comment 4 WebKit Commit Bot 2019-09-06 22:59:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-09-06 23:01:04 PDT 
<rdar://problem/55140532>