Bug 20156 - [Qt] build failure after r35293
Summary: [Qt] build failure after r35293
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-24 05:14 PDT by Gabor Loki
Modified: 2008-07-25 05:33 PDT (History)
0 users

See Also:


Attachments
proposed fix (6.22 KB, patch)
2008-07-24 05:21 PDT, Gabor Loki
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2008-07-24 05:14:08 PDT
I have a build failures after r35291 and r35293 on qt-linux.

The fail at r35291 comes from http://trac.webkit.org/changeset/35291/trunk/JavaScriptCore/kjs/ArgList.h change where operator[] method was removed.

The other fail at r35293 comes from http://trac.webkit.org/changeset/35293#file6 where a new include file (JSClassRef.h) was added to JSGlobalData.cpp.
Comment 1 Gabor Loki 2008-07-24 05:21:35 PDT
Created attachment 22461 [details]
proposed fix

The attached patch could fix the bug on qt-linux.

I have also checked the gtk-port on linux, and it seems OK.
I cannot able to test it on a Mac.
Comment 2 Eric Seidel (no email) 2008-07-24 16:02:25 PDT
Comment on attachment 22461 [details]
proposed fix

Can't do that:
-#include <JavaScriptCore/JSBase.h>
-#include <JavaScriptCore/JSValueRef.h>
+#include "JSBase.h"
+#include "JSValueRef.h"
 

You'll have to use some sort of ForwardingHeaders solution on linux.  See JavaScriptCore/ForwardingHeaders or WebCore/ForwardingHeaders
Comment 3 Eric Seidel (no email) 2008-07-24 16:02:45 PDT
Comment on attachment 22461 [details]
proposed fix

The API directory contains headers which Apple ships as API, in general we can't change those.
Comment 4 Gabor Loki 2008-07-25 05:33:28 PDT
It seems that the http://trac.webkit.org/changeset/35335 patch fixed the problem.