Bug 201559 - Web Inspector: CSS Formatter: links to CSS resources don't map to the right line after pretty printing if the line is after a multiline comment
Summary: Web Inspector: CSS Formatter: links to CSS resources don't map to the right l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-06 14:04 PDT by Devin Rousso
Modified: 2019-09-06 15:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2019-09-06 14:09 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-09-06 14:04:17 PDT 
Newlines in multiline comments weren't added as line endings, so they weren't considered when a source code location updated after pretty printing.
Comment 1 Devin Rousso 2019-09-06 14:09:14 PDT 
Created attachment 378234 [details]
Patch
Comment 2 Joseph Pecoraro 2019-09-06 14:20:44 PDT 
Comment on attachment 378234 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2019-09-06 14:21:00 PDT 
We should consider some way of testing this. I may look into it for the HTML formatter.
Comment 4 WebKit Commit Bot 2019-09-06 15:34:10 PDT 
Comment on attachment 378234 [details]
Patch

Clearing flags on attachment: 378234

Committed r249596: <https://trac.webkit.org/changeset/249596>
Comment 5 WebKit Commit Bot 2019-09-06 15:34:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-06 15:35:22 PDT 
<rdar://problem/55130685>