Bug 201538 - Web Inspector: Network: Error response headers summary has wrong color border
Summary: Web Inspector: Network: Error response headers summary has wrong color border
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-06 01:34 PDT by Joseph Pecoraro
Modified: 2019-09-06 02:15 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.51 KB, patch)
2019-09-06 01:36 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[IMAGE] Before (516.65 KB, image/png)
2019-09-06 01:36 PDT, Joseph Pecoraro 		no flags Details
[IMAGE] After (516.62 KB, image/png)
2019-09-06 01:37 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-09-06 01:34:51 PDT 
Network: Error response headers summary has wrong color border

Steps to Reproduce:
1. Inspect <http://example.com>
2. js> fetch("test")
3. Show Network tab
4. Select "test" request
5. Show Headers pane
  => summary section has green border but red text

Notes
• `body[dir] .resource-details > section.error > .details` gets overridden by
• `body[dir] .resource-headers > section.summary > .details` which comes later in CSS

Lets make resource-headers re-apply the error case to avoid additional specificity issues.
Comment 1 Radar WebKit Bug Importer 2019-09-06 01:35:12 PDT 
<rdar://problem/55104469>
Comment 2 Joseph Pecoraro 2019-09-06 01:36:11 PDT 
Created attachment 378167 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2019-09-06 01:36:39 PDT 
Created attachment 378168 [details]
[IMAGE] Before
Comment 4 Joseph Pecoraro 2019-09-06 01:37:00 PDT 
Created attachment 378169 [details]
[IMAGE] After
Comment 5 Devin Rousso 2019-09-06 01:44:10 PDT 
Comment on attachment 378167 [details]
[PATCH] Proposed Fix

rs=me
Comment 6 WebKit Commit Bot 2019-09-06 02:15:03 PDT 
Comment on attachment 378167 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 378167

Committed r249570: <https://trac.webkit.org/changeset/249570>
Comment 7 WebKit Commit Bot 2019-09-06 02:15:04 PDT 
All reviewed patches have been landed.  Closing bug.