Bug 201537 - [GStreamer] YUV buffers on iMX platforms have to be treated as RGBA
Summary: [GStreamer] YUV buffers on iMX platforms have to be treated as RGBA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-06 01:19 PDT by Zan Dobersek
Modified: 2019-09-06 01:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.37 KB, patch)
2019-09-06 01:29 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (9.32 KB, patch)
2019-09-06 01:50 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2019-09-06 01:19:12 PDT
[GStreamer] YUV buffers on iMX platforms have to be treated as RGBA
Comment 1 Zan Dobersek 2019-09-06 01:29:30 PDT
Created attachment 378166 [details]
Patch
Comment 2 Philippe Normand 2019-09-06 01:37:59 PDT
Comment on attachment 378166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378166&action=review

Looks good, I'll give it a test run on my board, please hold on :)

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2432
> +        else if (g_str_has_prefix(elementName.get(), "imxvpudecoder"))

Can you make the prefix a bit shorter? It would alloww to cover the gst-imx v2 branch if "imxvpudec" is used.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:237
> +                fprintf(stderr, "\tYUV but weird\n");

:)
Comment 3 Zan Dobersek 2019-09-06 01:50:28 PDT
Created attachment 378170 [details]
Patch
Comment 4 Zan Dobersek 2019-09-06 01:51:29 PDT
Comment on attachment 378170 [details]
Patch

Clearing flags on attachment: 378170

Committed r249568: <https://trac.webkit.org/changeset/249568>
Comment 5 Zan Dobersek 2019-09-06 01:51:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-06 01:52:15 PDT
<rdar://problem/55104803>
Comment 7 Radar WebKit Bug Importer 2019-09-06 01:52:16 PDT
<rdar://problem/55104807>