Bug 201514 – Web Inspector: Crashes when intercept response is a 404

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Web Inspector: Crashes when intercept response is a 404

Seems like the WebResourceLoader can sometimes go away and m_coreLoader may have gone away if the response is 400s.

[Joseph Pecoraro]

Created attachment 378117 [details]
[PATCH] Proposed Fix

[Alex Christensen]

Comment on attachment 378117 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=378117&action=review

> Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:147
> +        Ref<WebResourceLoader> interceptProtectedThis(*this);

Please just call it protectedThis, and do it in the lambda capture:
protectedThis = makeRef(*this)

[Joseph Pecoraro]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 378117 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=378117&action=review
> 
> > Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:147
> > +        Ref<WebResourceLoader> interceptProtectedThis(*this);
> 
> Please just call it protectedThis, and do it in the lambda capture:
> protectedThis = makeRef(*this)

There is already a `protectedThis` that may or may not be moved, which is why this is named separately.

[Joseph Pecoraro]

> > Please just call it protectedThis, and do it in the lambda capture:
> > protectedThis = makeRef(*this)
> 
> There is already a `protectedThis` that may or may not be moved, which is
> why this is named separately.

But I should be able to use that name again in the new lambdas.

[Joseph Pecoraro]

https://trac.webkit.org/changeset/249567/webkit

[Radar WebKit Bug Importer]

<rdar://problem/55104293>