Web Inspector: Crashes when intercept response is a 404 Seems like the WebResourceLoader can sometimes go away and m_coreLoader may have gone away if the response is 400s.
Created attachment 378117 [details] [PATCH] Proposed Fix
Comment on attachment 378117 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=378117&action=review > Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:147 > + Ref<WebResourceLoader> interceptProtectedThis(*this); Please just call it protectedThis, and do it in the lambda capture: protectedThis = makeRef(*this)
(In reply to Alex Christensen from comment #2) > Comment on attachment 378117 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=378117&action=review > > > Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:147 > > + Ref<WebResourceLoader> interceptProtectedThis(*this); > > Please just call it protectedThis, and do it in the lambda capture: > protectedThis = makeRef(*this) There is already a `protectedThis` that may or may not be moved, which is why this is named separately.
> > Please just call it protectedThis, and do it in the lambda capture: > > protectedThis = makeRef(*this) > > There is already a `protectedThis` that may or may not be moved, which is > why this is named separately. But I should be able to use that name again in the new lambdas.
https://trac.webkit.org/changeset/249567/webkit
<rdar://problem/55104293>