Bug 201510 - results.webkit.org: Assign notifyRerender before calling
Summary: results.webkit.org: Assign notifyRerender before calling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-09-05 11:31 PDT by Jonathan Bedard
Modified: 2019-09-05 16:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.98 KB, patch)
2019-09-05 11:33 PDT, Jonathan Bedard 		aakash_jain: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-09-05 11:31:16 PDT 
This bug doesn't have much of an effect, but it pollutes our console log.
Comment 1 Jonathan Bedard 2019-09-05 11:33:32 PDT 
Created attachment 378102 [details]
Patch
Comment 2 Aakash Jain 2019-09-05 15:09:17 PDT 
Comment on attachment 378102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378102&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:515
> +            // notify inside of the provider that we may changed the layout size because of expanded / unexpanded.

Nit: notify => Notify
Comment 3 Jonathan Bedard 2019-09-05 16:37:18 PDT 
Committed r249554: <https://trac.webkit.org/changeset/249554>
Comment 4 Radar WebKit Bug Importer 2019-09-05 16:38:19 PDT 
<rdar://problem/55090537>