RESOLVED FIXED201494
Comment in isSystemFont() no longer matches code 
https://bugs.webkit.org/show_bug.cgi?id=201494
Summary Comment in isSystemFont() no longer matches code
Daniel Bates
Reported 2019-09-04 23:49:50 PDT
Following <https://trac.webkit.org/changeset/247720/webkit> comment in <https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp?rev=249040#L795> no longer matches the code: [[ static inline bool isSystemFont(const String& family) { // AtomString's operator[] handles out-of-bounds by returning 0. return family[0] == '.'; } ]] Following r247720 function takes a String. Comment talks about AtomString.
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-09-05 00:10:14 PDT
Oh oops, we should probably update the comment.
Ahmad Saleem
Comment 2 2023-10-25 14:16:37 PDT
We still have following comment: https://github.com/WebKit/WebKit/blob/e93103f1a03a7acfe0b99029948079eeba36f059/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp#L222 // AtomString's operator[] handles out-of-bounds by returning 0. is to change? // String's operator[] handles out-of-bounds by returning 0. Happy to do unreviewed PR to change to above.
Ryosuke Niwa
Comment 3 2023-10-25 14:34:50 PDT
FWIW, we should probably go through a code review.
EWS
Comment 4 2023-10-25 15:01:33 PDT
Committed 269787@main (8e1a9a0da3d1): <https://commits.webkit.org/269787@main> Reviewed commits have been landed. Closing PR #19566 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-10-25 15:02:46 PDT
<rdar://problem/117498827>
Note You need to log in before you can comment on or make changes to this bug.