Bug 201488 - [JSC] Promise resolve/reject functions should be created more efficiently
Summary: [JSC] Promise resolve/reject functions should be created more efficiently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 198849
Blocks:
  Show dependency tree / graph
 
Reported: 2019-09-04 19:57 PDT by Yusuke Suzuki
Modified: 2019-09-09 15:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (12.55 KB, patch)
2019-09-09 03:40 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (12.57 KB, patch)
2019-09-09 03:43 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (14.13 KB, patch)
2019-09-09 04:01 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-09-04 19:57:38 PDT 
...
Comment 1 Yusuke Suzuki 2019-09-04 20:00:02 PDT 
bug 198849 fixes the critical issue, but it makes @resolve / @reject function creation more costly. And we know that this causes 7-8% regression in JetStream2/async-fs.
We should have a good mechanism to produce such a function without allocating FunctionRareData so that we can recover async-fs regression.
Comment 2 Radar WebKit Bug Importer 2019-09-04 20:00:22 PDT 
<rdar://problem/55052212>
Comment 3 Yusuke Suzuki 2019-09-09 03:40:07 PDT 
Created attachment 378360 [details]
Patch
Comment 4 Yusuke Suzuki 2019-09-09 03:43:00 PDT 
Created attachment 378361 [details]
Patch
Comment 5 Yusuke Suzuki 2019-09-09 04:01:28 PDT 
Created attachment 378363 [details]
Patch
Comment 6 Mark Lam 2019-09-09 08:36:23 PDT 
Comment on attachment 378363 [details]
Patch

Nice.  r=me
Comment 7 Yusuke Suzuki 2019-09-09 10:52:12 PDT 
Committed r249650: <https://trac.webkit.org/changeset/249650>
Comment 8 Saam Barati 2019-09-09 15:13:10 PDT 
Comment on attachment 378363 [details]
Patch

nice. r=me too