WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
201488
[JSC] Promise resolve/reject functions should be created more efficiently
https://bugs.webkit.org/show_bug.cgi?id=201488
Summary
[JSC] Promise resolve/reject functions should be created more efficiently
Yusuke Suzuki
Reported
2019-09-04 19:57:38 PDT
...
Attachments
Patch
(12.55 KB, patch)
2019-09-09 03:40 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(12.57 KB, patch)
2019-09-09 03:43 PDT
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
Patch
(14.13 KB, patch)
2019-09-09 04:01 PDT
,
Yusuke Suzuki
mark.lam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2019-09-04 20:00:02 PDT
bug 198849
fixes the critical issue, but it makes @resolve / @reject function creation more costly. And we know that this causes 7-8% regression in JetStream2/async-fs. We should have a good mechanism to produce such a function without allocating FunctionRareData so that we can recover async-fs regression.
Radar WebKit Bug Importer
Comment 2
2019-09-04 20:00:22 PDT
<
rdar://problem/55052212
>
Yusuke Suzuki
Comment 3
2019-09-09 03:40:07 PDT
Created
attachment 378360
[details]
Patch
Yusuke Suzuki
Comment 4
2019-09-09 03:43:00 PDT
Created
attachment 378361
[details]
Patch
Yusuke Suzuki
Comment 5
2019-09-09 04:01:28 PDT
Created
attachment 378363
[details]
Patch
Mark Lam
Comment 6
2019-09-09 08:36:23 PDT
Comment on
attachment 378363
[details]
Patch Nice. r=me
Yusuke Suzuki
Comment 7
2019-09-09 10:52:12 PDT
Committed
r249650
: <
https://trac.webkit.org/changeset/249650
>
Saam Barati
Comment 8
2019-09-09 15:13:10 PDT
Comment on
attachment 378363
[details]
Patch nice. r=me too
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug