RESOLVED FIXED 201486
[GTK][WPE] Do not enable the sandbox in Snap
https://bugs.webkit.org/show_bug.cgi?id=201486
Summary [GTK][WPE] Do not enable the sandbox in Snap
Patrick Griffis
Reported 2019-09-04 19:32:45 PDT
[GTK][WPE] Do not enable the sandbox in Snap
Attachments
Patch (1.99 KB, patch)
2019-09-04 19:34 PDT, Patrick Griffis
no flags
Patch (2.27 KB, patch)
2019-09-05 13:29 PDT, Patrick Griffis
no flags
Patrick Griffis
Comment 1 2019-09-04 19:34:51 PDT
Carlos Garcia Campos
Comment 2 2019-09-05 01:32:59 PDT
Comment on attachment 378039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378039&action=review > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:65 > + static int ret = -1; Use Optional<bool> instead. > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:69 > + ret = g_getenv("SNAP") != nullptr; Do not compare to nullptr.
Michael Catanzaro
Comment 3 2019-09-05 05:35:27 PDT
Comment on attachment 378039 [details] Patch And now we have a secret little envvar we can use to disable the sandbox for testing, that nobody else will likely be tempted to use. Cool.
Patrick Griffis
Comment 4 2019-09-05 13:29:39 PDT
Patrick Griffis
Comment 5 2019-09-05 13:30:42 PDT
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 378039 [details] > Patch > > And now we have a secret little envvar we can use to disable the sandbox for > testing, that nobody else will likely be tempted to use. Cool. WEBKIT_FORCE_SANDBOX=0 was already a thing.
Carlos Garcia Campos
Comment 6 2019-09-06 01:15:31 PDT
(In reply to Patrick Griffis from comment #5) > (In reply to Michael Catanzaro from comment #3) > > Comment on attachment 378039 [details] > > Patch > > > > And now we have a secret little envvar we can use to disable the sandbox for > > testing, that nobody else will likely be tempted to use. Cool. > > WEBKIT_FORCE_SANDBOX=0 was already a thing. I'm not sure that's checked at the right place, though. WebProcesdsPool::sandboxEnabled() will still return true.
WebKit Commit Bot
Comment 7 2019-09-06 02:00:11 PDT
Comment on attachment 378111 [details] Patch Clearing flags on attachment: 378111 Committed r249569: <https://trac.webkit.org/changeset/249569>
WebKit Commit Bot
Comment 8 2019-09-06 02:00:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.