Bug 201486 – [GTK][WPE] Do not enable the sandbox in Snap

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Patrick Griffis]

[GTK][WPE] Do not enable the sandbox in Snap

[Patrick Griffis]

Created attachment 378039 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 378039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378039&action=review

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:65
> +    static int ret = -1;

Use Optional<bool> instead.

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:69
> +    ret = g_getenv("SNAP") != nullptr;

Do not compare to nullptr.

[Michael Catanzaro]

Comment on attachment 378039 [details]
Patch

And now we have a secret little envvar we can use to disable the sandbox for testing, that nobody  else will likely be tempted to use. Cool.

[Patrick Griffis]

Created attachment 378111 [details]
Patch

[Patrick Griffis]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 378039 [details]
> Patch
> 
> And now we have a secret little envvar we can use to disable the sandbox for
> testing, that nobody  else will likely be tempted to use. Cool.

WEBKIT_FORCE_SANDBOX=0 was already a thing.

[Carlos Garcia Campos]

(In reply to Patrick Griffis from comment #5)
> (In reply to Michael Catanzaro from comment #3)
> > Comment on attachment 378039 [details]
> > Patch
> > 
> > And now we have a secret little envvar we can use to disable the sandbox for
> > testing, that nobody  else will likely be tempted to use. Cool.
> 
> WEBKIT_FORCE_SANDBOX=0 was already a thing.

I'm not sure that's checked at the right place, though. WebProcesdsPool::sandboxEnabled() will still return true.

[WebKit Commit Bot]

Comment on attachment 378111 [details]
Patch

Clearing flags on attachment: 378111

Committed r249569: <https://trac.webkit.org/changeset/249569>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.